Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web console: catchup to all the backend changes #14540

Merged
merged 18 commits into from
Jul 17, 2023

Conversation

vogievetsky
Copy link
Contributor

@vogievetsky vogievetsky commented Jul 7, 2023

This PR catches the console up to all the backend changes for Druid 27

Specifically:

In addition this PR also:

  • Adds a UI for dynamic compaction
    image
  • Allows formulas and decimals to be used in numeric inputs
    image
  • Fixes the auto refresh so it does not overwhelm the server
  • Fixes the JSX import to be explicit
  • Improves type definition (like MsqTaskPayloadResponse)
  • Fixes bug with how the data loader sets the splitHintSpec
  • Fixes issue with counter misalignment in MSQ input counters

@@ -60,17 +66,22 @@ FROM sys.segments`,
);

return {
total: availableSegmentNum + unavailableSegmentNum,
active: availableSegmentNum + unavailableSegmentNum,
cached_on_historical: availableSegmentNum, // This is not correct
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

export type ErrorResponseCategory =
| 'DEFENSIVE'
| 'INVALID_INPUT'
| 'UNAUTHORIZED'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is also FORBIDDEN (403 status), is it left out on purpose?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I took that list from here https://github.com/apache/druid/blob/master/processing/src/main/java/org/apache/druid/error/ErrorResponse.java#L43 but I guess I should have gone to the definition instead. Updated.

column: 19,
});
});
// it('works for single error 1', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why commented out?

@abhishekagarwal87 abhishekagarwal87 merged commit d5f6749 into apache:master Jul 17, 2023
74 checks passed
@vogievetsky vogievetsky deleted the console_catchup branch July 17, 2023 06:14
AmatyaAvadhanula pushed a commit to AmatyaAvadhanula/druid that referenced this pull request Jul 17, 2023
This PR catches the console up to all the backend changes for Druid 27

Specifically:

Add page information to SqlStatementResource API apache#14512
Allow empty tiered replicants map for load rules apache#14432
Adding Interactive API's for MSQ engine apache#14416
Add replication factor column to sys table apache#14403
Account for data format and compression in MSQ auto taskAssignment apache#14307
Errors take 3 apache#14004
abhishekagarwal87 pushed a commit that referenced this pull request Jul 17, 2023
This PR catches the console up to all the backend changes for Druid 27

Specifically:

Add page information to SqlStatementResource API #14512
Allow empty tiered replicants map for load rules #14432
Adding Interactive API's for MSQ engine #14416
Add replication factor column to sys table #14403
Account for data format and compression in MSQ auto taskAssignment #14307
Errors take 3 #14004

Co-authored-by: Vadim Ogievetsky <vadim@ogievetsky.com>
sergioferragut pushed a commit to sergioferragut/druid that referenced this pull request Jul 21, 2023
This PR catches the console up to all the backend changes for Druid 27

Specifically:

Add page information to SqlStatementResource API apache#14512
Allow empty tiered replicants map for load rules apache#14432
Adding Interactive API's for MSQ engine apache#14416
Add replication factor column to sys table apache#14403
Account for data format and compression in MSQ auto taskAssignment apache#14307
Errors take 3 apache#14004
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants