Remove unused coordinator dynamic configs #14524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please make changes to coordinator-dynamic-config.tsx and the configuration docs as well? |
|
Thanks for the reminder, @AmatyaAvadhanula ! |
AmatyaAvadhanula
approved these changes
Jul 6, 2023
sergioferragut
pushed a commit
to sergioferragut/druid
that referenced
this pull request
Jul 21, 2023
After apache#13197 , several coordinator configs are now redundant as they are not being used anymore, neither with `smartSegmentLoading` nor otherwise. Changes: - Remove dynamic configs `emitBalancingStats`: balancer error stats are always emitted, debug stats can be logged by using `debugDimensions` - `useBatchedSegmentSampler`, `percentOfSegmentsToConsiderPerMove`: batched segment sampling is always used - Add test to verify deserialization with unknown properties - Update `CoordinatorRunStats` to always track stats, this can be optimized later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After #13197 , several coordinator configs are now redundant as they are not being used anymore, neither with
smartSegmentLoadingnor otherwise.Changes
emitBalancingStats: balancer error stats are always emitted, debug stats can be logged by usingdebugDimensionsuseBatchedSegmentSampler,percentOfSegmentsToConsiderPerMove: batched segment sampling is always usedCoordinatorRunStatsto always track stats, even if the stat will never be emitted or logged.debugDimensionsto be passed toCostBalancerStrategyviaCostBalancerStrategyFactory.createStrategy(), which seems an overkill.Release note
The following Coordinator dynamic configs have been removed:
emitBalancingStats: Stats for errors encountered while balancing will always be emitted. Other debugging stats will not be emitted but can be logged by setting the appropriatedebugDimensions.useBatchedSegmentSampler,percentOfSegmentsToConsiderPerMove: Batched segment sampling is now the standard and will always be on.This PR has: