Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL: SUBSTRING support for non-literals. #14480

Merged
merged 4 commits into from
Jun 28, 2023
Merged

Conversation

gianm
Copy link
Contributor

@gianm gianm commented Jun 23, 2023

Enables using functions as inputs for the "index" or "length" parameters.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link
Member

@clintropolis clintropolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I wonder if i was a bit premature in marking makeExpression functions deprecated since they are a bit less tedious to use for tests.

@gianm gianm merged commit 34c55a0 into apache:master Jun 28, 2023
@gianm gianm deleted the expr-substr-dynamic branch June 28, 2023 20:43
@abhishekagarwal87 abhishekagarwal87 added this to the 27.0 milestone Jul 19, 2023
sergioferragut pushed a commit to sergioferragut/druid that referenced this pull request Jul 21, 2023
* SQL: SUBSTRING support for non-literals.

* Fix AssertionError test.

* Fix header.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants