Don't need to double synchronize on simple map operations #14435
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are using a lock around a concurrentHashMap for simple one line get/insert operations into the map
The concurrentHashMap guarantees that computeIfAbsent will only call the operation once if multiple threads attempt to call it concurrently, so this shouldn't be necessary.
We don't need the lock inside doTask either because doTask is called as a part of the operation in computeIfAbsent from either joinAsync or run for a single taskId. Because the map is concurrent, there will be one thread running doTask per taskId.
Release note
This PR has: