Add more statement attributes to explain plan result. #14391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishekrb19
changed the title
abhishekrb19
changed the title
amaechler
approved these changes
Jun 9, 2023
sql/src/main/java/org/apache/druid/sql/calcite/planner/ExplainAttributes.java
Outdated
Show resolved
Hide resolved
kfaraz
reviewed
Jun 10, 2023
sql/src/main/java/org/apache/druid/sql/calcite/planner/ExplainAttributes.java
Outdated
Show resolved
Hide resolved
sql/src/main/java/org/apache/druid/sql/calcite/planner/ExplainAttributes.java
Outdated
Show resolved
Hide resolved
sql/src/test/java/org/apache/druid/sql/avatica/DruidAvaticaHandlerTest.java
Outdated
Show resolved
Hide resolved
sql/src/test/java/org/apache/druid/sql/calcite/CalciteReplaceDmlTest.java
Show resolved
Hide resolved
Co-authored-by: Kashif Faraz <kashif.faraz@gmail.com>
Co-authored-by: Kashif Faraz <kashif.faraz@gmail.com>
…Attributes.java Co-authored-by: Kashif Faraz <kashif.faraz@gmail.com>
…krb19/incubator-druid into explain_plan_explicit_attributes
|
Thanks for the reviews! Since we're officially documenting attributes for the next release, I also added a new unit test to test the serialization part, so we don't accidentally change how things are serialized moving forward. |
kfaraz
reviewed
Jun 12, 2023
| @@ -107,6 +112,7 @@ public String getClusteredBy() | |||
| */ | |||
| @Nullable | |||
| @JsonProperty | |||
| @JsonInclude(JsonInclude.Include.NON_NULL) | |||
There was a problem hiding this comment.
Would it work to have this annotation just once at the class level instead?
There was a problem hiding this comment.
Yeah, it seems like we do a mix of method-level and class-level annotations in the codebase. Since we already do @Nullable consistently for all the methods in this class, I just stuck with the former.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following to the
ATTRIBUTEScolumn in the explain plan output:This PR leverages the work done in #14074, which added a new column
ATTRIBUTESto encapsulate all the statement-related attributes.Release note
EXPLAIN PLANresult includes a new columnATTRIBUTESthat describes the attributes of a query. Seedocs/querying/sql-translation.mdfor more information and examples.Key changed/added classes in this PR
ExplainAttributes.javaExplainAttributesTest.javaThis PR has: