allow DruidSchema to fallback to segment metadata 'type' if 'typeSignature' is null
#12016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ture is null, to avoid producing incorrect SQL schema if broker is upgraded to 0.23 before historicals
gianm
approved these changes
Dec 2, 2021
jihoonson
approved these changes
Dec 3, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a fallback mechanism to
DruidSchemato use the legacy 'type' string field of segment metadata results, after #11895 changedDruidSchemato use a new, richer,typeSignaturefield instead. This fixes an issue where the SQL schema for a datasource can be marked entirely asCOMPLEXtyped columns if a broker is updated to 0.23 before historical servers are, and will remain in this state until restarted or all segments have been moved to new servers after all historicals are upgraded. See #11713 (comment) for details.This PR has: