Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing "Loader=yaml.FullLoader" parameter in generate-binary-license and generate-binary-notice py scripts #11815

Merged

Conversation

davidferlay
Copy link
Contributor

@davidferlay davidferlay commented Oct 19, 2021

Fixes #11814.

Description


This PR has:

  • been self-reviewed.
  • been tested in a test Druid cluster.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.

@abhishekagarwal87 abhishekagarwal87 merged commit a7ee646 into apache:master Oct 19, 2021
@abhishekagarwal87
Copy link
Contributor

abhishekagarwal87 commented Oct 19, 2021

Merged since CI failures are unrelated. Thank you @davidferlay

@clintropolis
Copy link
Member

this PR seems to have broken the k8s integration test, which now fails with

File "/home/travis/build/apache/druid/distribution/bin/generate-binary-license.py", line 140, in generate_license
    licenses_list = list(yaml.load_all(registry_file, Loader=yaml.FullLoader))
AttributeError: module 'yaml' has no attribute 'FullLoader'

https://app.travis-ci.com/github/apache/druid/jobs/544715776#L1329

clintropolis added a commit that referenced this pull request Oct 22, 2021
…ate-binary-notice py scripts (#11815)"

This reverts commit a7ee646.
gianm pushed a commit that referenced this pull request Oct 23, 2021
…ate-binary-notice py scripts (#11815)" (#11832)

This reverts commit a7ee646.
@clintropolis
Copy link
Member

@davidferlay We had to revert this change to unblock CI, but it still seems worth doing, would you like to try again and see if you can determine why the k8s integration test was not passing and how to fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing "Loader=yaml.FullLoader" parameter in generate-binary-license and generate-binary-notice py scripts
3 participants