Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the packaging check step in travis build #11799

Merged
merged 1 commit into from
Oct 14, 2021
Merged

Fix the packaging check step in travis build #11799

merged 1 commit into from
Oct 14, 2021
+1 −1

Conversation

abhishekagarwal87
Copy link
Contributor

@abhishekagarwal87 abhishekagarwal87 commented Oct 14, 2021 •
edited
Loading

Packaging check is failing because of the following error

TypeError: load_all() missing 1 required positional argument: 'Loader'
[ERROR] Command execution failed.
org.apache.commons.exec.ExecuteException: Process exited with an error: 1 (Exit value: 1)
    at org.apache.commons.exec.DefaultExecutor.executeInternal (DefaultExecutor.java:404)
    at org.apache.commons.exec.DefaultExecutor.execute (DefaultExecutor.java:166)
    at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:804)
    at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:751)
    at org.codehaus.mojo.exec.ExecMojo.execute (ExecMojo.java:313)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:210)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
    at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call (MultiThreadedBuilder.java:190)
    at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call (MultiThreadedBuilder.java:186)
    at java.util.concurrent.FutureTask.run (FutureTask.java:266)
    at java.util.concurrent.Executors$RunnableAdapter.call (Executors.java:511)
    at java.util.concurrent.FutureTask.run (FutureTask.java:266)
    at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1149)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:624)
    at java.lang.Thread.run (Thread.java:748)

This is due to an incompatible API change in recent version of pyyaml module. I am hardcoding the version of pyyaml in .travis.yml so that build outcome is not environment-specific.

cryptoe
cryptoe reviewed Oct 14, 2021
View reviewed changes
.travis.yml
@@ -94,7 +94,7 @@ jobs:
- sudo apt-get update && sudo apt-get install python3 python3-pip python3-setuptools -y
- ./check_test_suite.py && travis_terminate 0 || echo 'Continuing setup'
- pip3 install wheel # install wheel first explicitly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit : should we also fix wheel version ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't think it's needed but I can see the argument for that too. There may be more of such dependencies that I am not looking at. Let me unblock the builds first and can hard-code versions of other dependencies in a follow-up PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was being opportunistic 🚀 🎸 !!

@cryptoe
Copy link
Contributor

cryptoe commented Oct 14, 2021

lgtm after ci cd passes !!

@abhishekagarwal87 abhishekagarwal87 merged commit 4f62905 into apache:master Oct 14, 2021
@JulianJaffePinterest JulianJaffePinterest mentioned this pull request Oct 27, 2021
Merged
9 tasks
JulianJaffePinterest added a commit to JulianJaffePinterest/druid that referenced this pull request Oct 27, 2021
@JulianJaffePinterest
Copy the fix for apache#11799.
7f7f251
gianm pushed a commit that referenced this pull request Dec 10, 2021
@abhishekagarwal87 @gianm
Fix the travis build (#11799)
ad1ee13
@jihoonson jihoonson added this to the 0.22.1 milestone Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptoe cryptoe cryptoe left review comments

@clintropolis clintropolis clintropolis approved these changes

Assignees
No one assigned
Labels
Area - Testing
Projects
None yet
Milestone
0.22.1
Development

Successfully merging this pull request may close these issues.
4 participants
@abhishekagarwal87 @cryptoe @clintropolis @jihoonson