Remove stale 'namespace' config for JDBC lookups from doc #10886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capistrant
reviewed
Feb 15, 2021
| @@ -268,22 +268,6 @@ export const LOOKUP_FIELDS: Field<LookupSpec>[] = [ | |||
| }, | |||
|
|
|||
| // JDBC stuff | |||
| { | |||
There was a problem hiding this comment.
From looking at Travis failure, It looks like this requires a snapshot update. jest --updateSnapshot
There was a problem hiding this comment.
Thanks for the review. I reverted this change in favor of #10888.
capistrant
requested changes
Feb 16, 2021
| @@ -377,7 +375,8 @@ The JDBC lookups will poll a database to populate its local cache. If the `tsCol | |||
| > If using JDBC, you will need to add your database's client JAR files to the extension's directory. | |||
| > For Postgres, the connector JAR is already included. | |||
| > For MySQL, you can get it from https://dev.mysql.com/downloads/connector/j/. | |||
| > Copy or symlink the downloaded file to `extensions/druid-lookups-cached-global` under the distribution root directory. | |||
| > The connector JAR should locate in the classpath of Druid's main class loader. | |||
| > An easy way to add it in the classpath is copying or symlinking the downloaded file to `lib/` under the distribution root directory. | |||
There was a problem hiding this comment.
looks like "symlinking" is called out by spell checker. I think it would be fine to add it to the dictionary in the website module. Might not be in a common dictionary, but from a computing standpoint it is a valid word IMO.
There was a problem hiding this comment.
I agree it's valid, but deleted it by addressing @techdocsmith's comment below.
jihoonson
changed the title
| @@ -377,7 +375,8 @@ The JDBC lookups will poll a database to populate its local cache. If the `tsCol | |||
| > If using JDBC, you will need to add your database's client JAR files to the extension's directory. | |||
| > For Postgres, the connector JAR is already included. | |||
| > For MySQL, you can get it from https://dev.mysql.com/downloads/connector/j/. | |||
| > Copy or symlink the downloaded file to `extensions/druid-lookups-cached-global` under the distribution root directory. | |||
| > The connector JAR should locate in the classpath of Druid's main class loader. | |||
There was a problem hiding this comment.
Suggested change
| > The connector JAR should locate in the classpath of Druid's main class loader. | |
| > The connector JAR should reside in the classpath of Druid's main class loader. |
reside or "be located?"
| @@ -377,7 +375,8 @@ The JDBC lookups will poll a database to populate its local cache. If the `tsCol | |||
| > If using JDBC, you will need to add your database's client JAR files to the extension's directory. | |||
| > For Postgres, the connector JAR is already included. | |||
| > For MySQL, you can get it from https://dev.mysql.com/downloads/connector/j/. | |||
| > Copy or symlink the downloaded file to `extensions/druid-lookups-cached-global` under the distribution root directory. | |||
| > The connector JAR should locate in the classpath of Druid's main class loader. | |||
| > An easy way to add it in the classpath is copying or symlinking the downloaded file to `lib/` under the distribution root directory. | |||
There was a problem hiding this comment.
Suggested change
| > An easy way to add it in the classpath is copying or symlinking the downloaded file to `lib/` under the distribution root directory. | |
| > To add the connector JAR to the classpath, you can copy the downloaded file to `lib/` under the distribution root directory. Alternatively, create a symbolic link to the connector in the `lib` directory. |
|
@techdocsmith thanks, I addressed your comments. |
|
@capistrant do you have more comments? |
|
@capistrant thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
namespaceconfig was removed in #2926. Also fixed a wrong instruction for the JDBC connector location.This PR has: