Skip to content

Commit

Permalink
SuperSorter: Store readOnly output channels. (#16928)
Browse files Browse the repository at this point in the history
Without the call to readOnly, each output channel retains a 1 MB allocator,
leading to excessive memory use. Fixes regression from #16775.
  • Loading branch information
gianm authored Aug 21, 2024
1 parent 0ce1b6b commit f6adacf
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -670,7 +670,7 @@ private void runMerger(
final OutputChannel outputChannel = outputChannelFactory.openChannel(intRank);
writableChannel = outputChannel.getWritableChannel();
frameAllocatorFactory = new SingleMemoryAllocatorFactory(outputChannel.getFrameMemoryAllocator());
outputChannels.set(intRank, outputChannel);
outputChannels.set(intRank, outputChannel.readOnly());

if (totalMergingLevels == 1) {
// Reading from the inputBuffer. (i.e. "direct mode"; see class-level javadoc for more details.)
Expand Down

0 comments on commit f6adacf

Please sign in to comment.