review comment: add Nullable annotations

apache · Apr 12, 2023 · eeddf19 · eeddf19
1 parent fba9e43
commit eeddf19
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 3 deletions.
diff --git a/sql/src/main/java/org/apache/druid/sql/calcite/planner/IngestHandler.java b/sql/src/main/java/org/apache/druid/sql/calcite/planner/IngestHandler.java
@@ -49,6 +49,7 @@
 import org.apache.druid.sql.calcite.run.EngineFeature;
 import org.apache.druid.sql.calcite.run.QueryMaker;
 
+import javax.annotation.Nullable;
 import java.util.List;
 import java.util.regex.Pattern;
 
@@ -280,6 +281,7 @@ public String statementKind()
       return DruidSqlInsert.OPERATOR.getName();
     }
 
+    @Nullable
     @Override
     public SqlNode targetDataSource()
     {
@@ -350,6 +352,7 @@ public String statementKind()
       return DruidSqlReplace.OPERATOR.getName();
     }
 
+    @Nullable
     @Override
     public SqlNode targetDataSource()
     {

diff --git a/sql/src/main/java/org/apache/druid/sql/calcite/planner/PlannerContext.java b/sql/src/main/java/org/apache/druid/sql/calcite/planner/PlannerContext.java
@@ -513,14 +513,15 @@ public String getStatementKind()
     return this.statementKind;
   }
 
-  public void setStatementKind(String sqlKind)
+  public void setStatementKind(String statementKind)
   {
     if (this.statementKind != null) {
       throw new ISE("StatementKind has already been set");
     }
-    this.statementKind = sqlKind;
+    this.statementKind = statementKind;
   }
 
+  @Nullable
   public SqlNode getTargetDataSource()
   {
     return this.targetDataSource;

diff --git a/sql/src/main/java/org/apache/druid/sql/calcite/planner/QueryHandler.java b/sql/src/main/java/org/apache/druid/sql/calcite/planner/QueryHandler.java
@@ -234,6 +234,7 @@ public String statementKind()
     return "SELECT";
   }
 
+  @Nullable
   @Override
   public SqlNode targetDataSource()
   {

diff --git a/sql/src/main/java/org/apache/druid/sql/calcite/planner/SqlStatementHandler.java b/sql/src/main/java/org/apache/druid/sql/calcite/planner/SqlStatementHandler.java
@@ -28,6 +28,7 @@
 import org.apache.druid.sql.calcite.run.SqlEngine;
 import org.joda.time.DateTimeZone;
 
+import javax.annotation.Nullable;
 import java.util.Map;
 import java.util.Set;
 
@@ -43,7 +44,7 @@ public interface SqlStatementHandler
   PrepareResult prepareResult();
   PlannerResult plan() throws ValidationException;
   String statementKind();
-  SqlNode targetDataSource();
+  @Nullable SqlNode targetDataSource();
 
   /**
    * Context available to statement handlers.