Addressing comments

apache · Aug 2, 2023 · e35a906 · e35a906
1 parent 32bca40
commit e35a906
Show file tree

Hide file tree

Showing 16 changed files with 14 additions and 20 deletions.
diff --git a/processing/src/main/java/org/apache/druid/query/aggregation/first/DoubleFirstAggregator.java b/processing/src/main/java/org/apache/druid/query/aggregation/first/DoubleFirstAggregator.java
@@ -34,7 +34,7 @@ public DoubleFirstAggregator(BaseLongColumnValueSelector timeSelector, ColumnVal
   }
 
   @Override
-  void setFirstValue(ColumnValueSelector valueSelector)
+  void setFirstValue()
   {
     firstValue = valueSelector.getDouble();
   }

diff --git a/.../src/main/java/org/apache/druid/query/aggregation/first/DoubleFirstAggregatorFactory.java b/.../src/main/java/org/apache/druid/query/aggregation/first/DoubleFirstAggregatorFactory.java
@@ -238,7 +238,6 @@ public byte[] getCacheKey()
   @Override
   public ColumnType getIntermediateType()
   {
-    // if we don't pretend to be a primitive, group by v1 gets sad and doesn't work because no complex type serde
     return TYPE;
   }
 

diff --git a/processing/src/main/java/org/apache/druid/query/aggregation/first/FloatFirstAggregator.java b/processing/src/main/java/org/apache/druid/query/aggregation/first/FloatFirstAggregator.java
@@ -38,7 +38,7 @@ public FloatFirstAggregator(
   }
 
   @Override
-  void setFirstValue(ColumnValueSelector valueSelector)
+  void setFirstValue()
   {
     firstValue = valueSelector.getFloat();
   }

diff --git a/...g/src/main/java/org/apache/druid/query/aggregation/first/FloatFirstAggregatorFactory.java b/...g/src/main/java/org/apache/druid/query/aggregation/first/FloatFirstAggregatorFactory.java
@@ -235,7 +235,6 @@ public byte[] getCacheKey()
   @Override
   public ColumnType getIntermediateType()
   {
-    // if we don't pretend to be a primitive, group by v1 gets sad and doesn't work because no complex type serde
     return TYPE;
   }
 

diff --git a/processing/src/main/java/org/apache/druid/query/aggregation/first/LongFirstAggregator.java b/processing/src/main/java/org/apache/druid/query/aggregation/first/LongFirstAggregator.java
@@ -34,7 +34,7 @@ public LongFirstAggregator(BaseLongColumnValueSelector timeSelector, ColumnValue
   }
 
   @Override
-  void setFirstValue(ColumnValueSelector valueSelector)
+  void setFirstValue()
   {
     firstValue = valueSelector.getLong();
   }

diff --git a/...ng/src/main/java/org/apache/druid/query/aggregation/first/LongFirstAggregatorFactory.java b/...ng/src/main/java/org/apache/druid/query/aggregation/first/LongFirstAggregatorFactory.java
@@ -234,7 +234,6 @@ public byte[] getCacheKey()
   @Override
   public ColumnType getIntermediateType()
   {
-    // if we don't pretend to be a primitive, group by v1 gets sad and doesn't work because no complex type serde
     return TYPE;
   }
 

diff --git a/...essing/src/main/java/org/apache/druid/query/aggregation/first/NumericFirstAggregator.java b/...essing/src/main/java/org/apache/druid/query/aggregation/first/NumericFirstAggregator.java
@@ -52,7 +52,7 @@ public NumericFirstAggregator(BaseLongColumnValueSelector timeSelector, ColumnVa
   /**
    * Store the current primitive typed 'first' value
    */
-  abstract void setFirstValue(ColumnValueSelector valueSelector);
+  abstract void setFirstValue();
 
   /**
    * Store a non-null first value
@@ -71,7 +71,7 @@ public void aggregate()
       if (object instanceof SerializablePair) {
         SerializablePair<Long, Number> inPair = (SerializablePair<Long, Number>) object;
 
-        if (inPair != null && inPair.lhs < firstTime) {
+        if (inPair.lhs < firstTime) {
           firstTime = inPair.lhs;
           if (inPair.rhs == null) {
             rhsNull = true;
@@ -88,7 +88,7 @@ public void aggregate()
     if (time < firstTime) {
       firstTime = time;
       if (useDefault || !valueSelector.isNull()) {
-        setFirstValue(valueSelector);
+        setFirstValue();
         rhsNull = false;
       } else {
         setFirstValue(0);

diff --git a/.../src/main/java/org/apache/druid/query/aggregation/first/NumericFirstBufferAggregator.java b/.../src/main/java/org/apache/druid/query/aggregation/first/NumericFirstBufferAggregator.java
@@ -106,7 +106,7 @@ public void aggregate(ByteBuffer buf, int position)
       final Object object = valueSelector.getObject();
       if (object instanceof SerializablePair) {
         final SerializablePair<Long, Number> inPair = (SerializablePair<Long, Number>) object;
-        if (inPair != null && inPair.lhs < firstTime) {
+        if (inPair.lhs < firstTime) {
           if (inPair.rhs == null) {
             updateTimeWithNull(buf, position, inPair.lhs);
           } else {

diff --git a/processing/src/main/java/org/apache/druid/query/aggregation/last/DoubleLastAggregator.java b/processing/src/main/java/org/apache/druid/query/aggregation/last/DoubleLastAggregator.java
@@ -34,7 +34,7 @@ public DoubleLastAggregator(BaseLongColumnValueSelector timeSelector, ColumnValu
   }
 
   @Override
-  void setLastValue(ColumnValueSelector valueSelector)
+  void setLastValue()
   {
     lastValue = valueSelector.getDouble();
   }

diff --git a/...ng/src/main/java/org/apache/druid/query/aggregation/last/DoubleLastAggregatorFactory.java b/...ng/src/main/java/org/apache/druid/query/aggregation/last/DoubleLastAggregatorFactory.java
@@ -265,7 +265,6 @@ public byte[] getCacheKey()
   @Override
   public ColumnType getIntermediateType()
   {
-    // if we don't pretend to be a primitive, group by v1 gets sad and doesn't work because no complex type serde
     return TYPE;
   }
 

diff --git a/processing/src/main/java/org/apache/druid/query/aggregation/last/FloatLastAggregator.java b/processing/src/main/java/org/apache/druid/query/aggregation/last/FloatLastAggregator.java
@@ -34,7 +34,7 @@ public FloatLastAggregator(BaseLongColumnValueSelector timeSelector, ColumnValue
   }
 
   @Override
-  void setLastValue(ColumnValueSelector valueSelector)
+  void setLastValue()
   {
     lastValue = valueSelector.getFloat();
   }

diff --git a/...ing/src/main/java/org/apache/druid/query/aggregation/last/FloatLastAggregatorFactory.java b/...ing/src/main/java/org/apache/druid/query/aggregation/last/FloatLastAggregatorFactory.java
@@ -264,7 +264,6 @@ public byte[] getCacheKey()
   @Override
   public ColumnType getIntermediateType()
   {
-    // if we don't pretend to be a primitive, group by v1 gets sad and doesn't work because no complex type serde
     return TYPE;
   }
 

diff --git a/processing/src/main/java/org/apache/druid/query/aggregation/last/LongLastAggregator.java b/processing/src/main/java/org/apache/druid/query/aggregation/last/LongLastAggregator.java
@@ -34,7 +34,7 @@ public LongLastAggregator(BaseLongColumnValueSelector timeSelector, ColumnValueS
   }
 
   @Override
-  void setLastValue(ColumnValueSelector valueSelector)
+  void setLastValue()
   {
     lastValue = valueSelector.getLong();
   }

diff --git a/...sing/src/main/java/org/apache/druid/query/aggregation/last/LongLastAggregatorFactory.java b/...sing/src/main/java/org/apache/druid/query/aggregation/last/LongLastAggregatorFactory.java
@@ -262,7 +262,6 @@ public byte[] getCacheKey()
   @Override
   public ColumnType getIntermediateType()
   {
-    // if we don't pretend to be a primitive, group by v1 gets sad and doesn't work because no complex type serde
     return TYPE;
   }
 

diff --git a/processing/src/main/java/org/apache/druid/query/aggregation/last/NumericLastAggregator.java b/processing/src/main/java/org/apache/druid/query/aggregation/last/NumericLastAggregator.java
@@ -54,7 +54,7 @@ public NumericLastAggregator(BaseLongColumnValueSelector timeSelector, ColumnVal
   /**
    * Store the current primitive typed 'last' value
    */
-  abstract void setLastValue(ColumnValueSelector valueSelector);
+  abstract void setLastValue();
 
   abstract void setLastValue(Number lastValue);
 
@@ -70,7 +70,7 @@ public void aggregate()
       if (object instanceof SerializablePair) {
         final SerializablePair<Long, Number> inPair = (SerializablePair<Long, Number>) object;
 
-        if (inPair != null && inPair.lhs >= lastTime) {
+        if (inPair.lhs >= lastTime) {
           lastTime = inPair.lhs;
 
           if (inPair.rhs == null) {
@@ -88,7 +88,7 @@ public void aggregate()
     if (time >= lastTime) {
       lastTime = time;
       if (useDefault || !valueSelector.isNull()) {
-        setLastValue(valueSelector);
+        setLastValue();
         rhsNull = false;
       } else {
         setLastValue(0);

diff --git a/...ng/src/main/java/org/apache/druid/query/aggregation/last/NumericLastBufferAggregator.java b/...ng/src/main/java/org/apache/druid/query/aggregation/last/NumericLastBufferAggregator.java
@@ -110,7 +110,7 @@ public void aggregate(ByteBuffer buf, int position)
       if (object instanceof SerializablePair) {
         final SerializablePair<Long, Number> inPair = (SerializablePair<Long, Number>) object;
 
-        if (inPair != null && inPair.lhs >= lastTime) {
+        if (inPair.lhs >= lastTime) {
           if (inPair.rhs == null) {
             updateTimeWithNull(buf, position, inPair.lhs);
           } else {