[Thread] Add thread local variable ThreadContext #7234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinyiZzz
force-pushed
the
thread_loacl_single
branch
2 times, most recently
from
25ed800
to
6153b53
Compare
xinyiZzz
changed the title
xinyiZzz
force-pushed
the
thread_loacl_single
branch
from
6153b53
to
f2e2c08
Compare
yangzhg
reviewed
Dec 6, 2021
yangzhg
reviewed
Dec 6, 2021
yangzhg
reviewed
Dec 6, 2021
yangzhg
reviewed
Dec 6, 2021
xinyiZzz
force-pushed
the
thread_loacl_single
branch
2 times, most recently
from
2ac3493
to
2193b6d
Compare
xinyiZzz
force-pushed
the
thread_loacl_single
branch
3 times, most recently
from
1053895
to
b4adb7a
Compare
xinyiZzz
force-pushed
the
thread_loacl_single
branch
from
b4adb7a
to
44d9a33
Compare
morningman
added
dev/backlog
morningman
reviewed
Mar 8, 2022
be/src/runtime/thread_context.h
Outdated
| // So, kudu Class-scoped static thread local implementation was introduced. Solve the above problem by | ||
| // Thread-scopedthread local + Class-scoped thread local. | ||
| // | ||
| // This may look very track, but it's the best way I can find. |
There was a problem hiding this comment.
Suggested change
| // This may look very track, but it's the best way I can find. | |
| // This may look very trick, but it's the best way I can find. |
be/src/runtime/thread_context.h
Outdated
| public: | ||
| explicit AttachTaskThread(const ThreadContext::TaskType& type, const std::string& task_id, | ||
| const TUniqueId& fragment_instance_id) { | ||
| DCHECK(task_id != "" && fragment_instance_id != TUniqueId()); |
There was a problem hiding this comment.
If this is not a query task , the fragment_instance_id maybe empty.
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. |
There was a problem hiding this comment.
If this file is copied from other project, better add a comment.
Same as other file in this PR.
There was a problem hiding this comment.
done, in threadlocal.h
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
cambyzju
pushed a commit
to cambyzju/incubator-doris
that referenced
this pull request
Mar 12, 2022
…he#7234) The thread context saves some info about a working thread. 1. thread_id: Current thread id, Auto generated. 2. type: The type is a enum value indicating which type of task current thread is running. For example: QUERY, LOAD, COMPACTION, ... 3. task id: A unique id to identify this task. maybe query id, load job id, etc. Using gcc11 compiles thread_local variable on lower versions of GLIBC will report an error, see apache#7911 This is very difficult to solve, so kudu Class-scoped static thread local implementation was introduced. Solve the above problem by Thread-scopedthread local + Class-scoped thread local. See the comments for ThreadContextPtr for details.
morningman
pushed a commit
that referenced
this pull request
Mar 14, 2022
The thread context saves some info about a working thread.
1. thread_id: Current thread id, Auto generated.
2. type: The type is a enum value indicating which type of task current thread is running.
For example: QUERY, LOAD, COMPACTION, ...
3. task id: A unique id to identify this task. maybe query id, load job id, etc.
Using gcc11 compiles thread_local variable on lower versions of GLIBC will report an error, see #7911
This is very difficult to solve, so kudu Class-scoped static thread local implementation was introduced.
Solve the above problem by Thread-scopedthread local + Class-scoped thread local.
See the comments for ThreadContextPtr for details.
morningman
added
dev/merged-1.0.1-deprecated
zhengte
pushed a commit
to zhengte/incubator-doris
that referenced
this pull request
Mar 15, 2022
…he#7234) The thread context saves some info about a working thread. 1. thread_id: Current thread id, Auto generated. 2. type: The type is a enum value indicating which type of task current thread is running. For example: QUERY, LOAD, COMPACTION, ... 3. task id: A unique id to identify this task. maybe query id, load job id, etc. Using gcc11 compiles thread_local variable on lower versions of GLIBC will report an error, see apache#7911 This is very difficult to solve, so kudu Class-scoped static thread local implementation was introduced. Solve the above problem by Thread-scopedthread local + Class-scoped thread local. See the comments for ThreadContextPtr for details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The thread context saves some info about a working thread.
For example: QUERY, LOAD, COMPACTION, ...
Using gcc11 compiles thread_local variable on lower versions of GLIBC will report an error, see #7911
This is very difficult to solve, so kudu Class-scoped static thread local implementation was introduced. Solve the above problem by Thread-scopedthread local + Class-scoped thread local. See the comments for ThreadContextPtr for details.
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...