Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] fix compression bug while compaction #5893

Merged
merged 2 commits into from
May 26, 2021

Conversation

stdpain
Copy link
Contributor

@stdpain stdpain commented May 24, 2021

Because the maximum length of LZ4 compression is 2^32, it can cause some memory problems

Proposed changes

will close #5892
may fix #5849 problem 2

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If these changes need document changes, I have updated the document
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Because the maximum length of LZ4 compression is 2^32, it can cause some memory problems
@EmmyMiao87 EmmyMiao87 added area/storage Issues or PRs related to storage engine kind/fix Categorizes issue or PR as related to a bug. labels May 25, 2021
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added the approved Indicates a PR has been approved by one committer. label May 25, 2021
@morningman morningman merged commit 6924637 into apache:master May 26, 2021
stdpain added a commit to stdpain/incubator-doris that referenced this pull request Jul 8, 2021
Because the maximum length of LZ4 compression is 2^32, it can cause some memory problems
@stdpain stdpain deleted the fix_compress_compaction_bug branch November 21, 2021 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. area/storage Issues or PRs related to storage engine kind/fix Categorizes issue or PR as related to a bug.
Projects
None yet
3 participants