Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve](mow) merge and remove old version of delete bitmap when cumulative compaction is done #42479

Open
wants to merge 2 commits into
base: branch-2.1
Choose a base branch
from

Conversation

hust-hhb
Copy link
Contributor

pick pr #40204 to branch 2.1

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@hust-hhb
Copy link
Contributor Author

run buildall

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions


#pragma once

#include <stdint.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: inclusion of deprecated C++ header 'stdint.h'; consider using 'cstdint' instead [modernize-deprecated-headers]

Suggested change
#include <stdint.h>
#include <cstdint>

private:
Status _handle_show_delete_bitmap_count(HttpRequest* req, std::string* json_result);

private:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: redundant access specifier has the same accessibility as the previous access specifier [readability-redundant-access-specifiers]

Suggested change
private:
Additional context

be/src/http/action/delete_bitmap_action.h:44: previously declared here

private:
^

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.03% (9372/26009)
Line Coverage: 27.59% (76977/278971)
Region Coverage: 26.38% (39533/149875)
Branch Coverage: 23.16% (20108/86826)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f0c514e9399df555cc4107808ed766f7dff16c50_f0c514e9399df555cc4107808ed766f7dff16c50/report/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants