-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug](exchange)fix the exchange not skip offset rows #42190
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
clang-tidy review says "All clean, LGTM! 👍" |
run buildall |
TeamCity be ut coverage result: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
before the fix, the exchange operator will return some error result. the `set_num_rows` function will save some rows[0, length), remove others; but here need skip offset rows, so need skip[0,offset) rows, should use `skip_num_rows`.
before the fix, the exchange operator will return some error result. the `set_num_rows` function will save some rows[0, length), remove others; but here need skip offset rows, so need skip[0,offset) rows, should use `skip_num_rows`.
Proposed changes
before the fix, the exchange operator will return some error result.
the
set_num_rows
function will save some rows[0, length), remove others;but here need skip offset rows, so need skip[0,offset) rows, should use
skip_num_rows
.