[Bug](exchange)fix the exchange not skip offset rows #42190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
TeamCity be ut coverage result: |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
jacktengg
approved these changes
Oct 22, 2024
zhangstar333
added a commit
to zhangstar333/incubator-doris
that referenced
this pull request
Oct 23, 2024
before the fix, the exchange operator will return some error result. the `set_num_rows` function will save some rows[0, length), remove others; but here need skip offset rows, so need skip[0,offset) rows, should use `skip_num_rows`.
zhangstar333
added a commit
to zhangstar333/incubator-doris
that referenced
this pull request
Oct 23, 2024
yiguolei
pushed a commit
that referenced
this pull request
Oct 24, 2024
zhangstar333
added a commit
that referenced
this pull request
Oct 24, 2024
zhangstar333
added a commit
to zhangstar333/incubator-doris
that referenced
this pull request
Oct 25, 2024
before the fix, the exchange operator will return some error result. the `set_num_rows` function will save some rows[0, length), remove others; but here need skip offset rows, so need skip[0,offset) rows, should use `skip_num_rows`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
before the fix, the exchange operator will return some error result.
the
set_num_rowsfunction will save some rows[0, length), remove others;but here need skip offset rows, so need skip[0,offset) rows, should use
skip_num_rows.