Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix](external) Prevent multiple fs from being generated #39663

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

wuwenchi
Copy link
Contributor

Proposed changes

If the user has already registered, there is no need to register again, otherwise fs will generate multiple instances.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@wuwenchi
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 38363 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a6109335d76a38850b6097ba1560200fc0633964, data reload: false

------ Round 1 ----------------------------------
q1	18229	4490	4404	4404
q2	2868	211	233	211
q3	11011	1123	1170	1123
q4	10875	809	702	702
q5	7794	2888	2852	2852
q6	270	161	160	160
q7	1002	668	670	668
q8	9395	2082	2090	2082
q9	7329	6598	6555	6555
q10	7043	2212	2312	2212
q11	507	275	275	275
q12	418	252	249	249
q13	18994	2994	3001	2994
q14	294	256	247	247
q15	563	513	522	513
q16	528	408	414	408
q17	989	728	716	716
q18	7411	7015	6756	6756
q19	6882	1022	1106	1022
q20	721	341	356	341
q21	3872	2930	2832	2832
q22	1122	1041	1042	1041
Total cold run time: 118117 ms
Total hot run time: 38363 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4490	4278	4340	4278
q2	399	308	309	308
q3	2883	2582	2651	2582
q4	1890	1657	1682	1657
q5	5336	5378	5385	5378
q6	232	144	142	142
q7	2115	1705	1707	1705
q8	3204	3348	3395	3348
q9	8403	8380	8383	8380
q10	3435	3204	3223	3204
q11	645	527	536	527
q12	833	638	644	638
q13	16719	2997	3029	2997
q14	316	311	290	290
q15	564	524	530	524
q16	514	443	444	443
q17	1790	1497	1506	1497
q18	7861	7729	7552	7552
q19	1728	1540	1506	1506
q20	2043	1849	1864	1849
q21	9577	5215	5107	5107
q22	1172	1080	1076	1076
Total cold run time: 76149 ms
Total hot run time: 54988 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 191040 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a6109335d76a38850b6097ba1560200fc0633964, data reload: false

query1	1018	406	403	403
query2	6735	2045	1961	1961
query3	6665	225	238	225
query4	34308	23249	23351	23249
query5	4375	721	724	721
query6	326	222	207	207
query7	4618	350	329	329
query8	467	424	426	424
query9	8652	2536	2526	2526
query10	507	361	362	361
query11	17840	15227	15258	15227
query12	190	139	135	135
query13	1710	460	456	456
query14	10209	7329	6256	6256
query15	284	193	191	191
query16	8108	507	498	498
query17	1719	620	596	596
query18	2161	346	360	346
query19	359	177	168	168
query20	139	139	140	139
query21	242	147	144	144
query22	4280	3998	3909	3909
query23	34072	33350	33541	33350
query24	11217	2973	2957	2957
query25	648	422	450	422
query26	1162	183	182	182
query27	2185	309	305	305
query28	6998	2123	2101	2101
query29	846	450	449	449
query30	333	185	187	185
query31	1058	845	853	845
query32	117	83	81	81
query33	813	352	346	346
query34	915	536	510	510
query35	901	779	790	779
query36	1110	974	965	965
query37	177	101	106	101
query38	3998	3940	3927	3927
query39	1519	1475	1472	1472
query40	248	164	152	152
query41	138	137	136	136
query42	140	118	121	118
query43	539	508	507	507
query44	1253	793	815	793
query45	228	200	197	197
query46	1138	793	781	781
query47	1945	1835	1898	1835
query48	407	342	340	340
query49	1227	589	582	582
query50	864	475	484	475
query51	7164	7136	7015	7015
query52	120	114	108	108
query53	304	231	226	226
query54	958	518	498	498
query55	90	90	90	90
query56	346	331	320	320
query57	1188	1103	1124	1103
query58	307	298	319	298
query59	3018	2838	2936	2838
query60	359	332	342	332
query61	178	150	149	149
query62	867	718	700	700
query63	265	231	226	226
query64	5248	2402	1858	1858
query65	3218	3169	3172	3169
query66	1137	683	684	683
query67	15592	15037	14879	14879
query68	8251	613	612	612
query69	743	398	355	355
query70	1244	1135	1181	1135
query71	559	316	355	316
query72	7412	2320	2092	2092
query73	1039	361	374	361
query74	9249	8993	8836	8836
query75	5049	2805	2734	2734
query76	4941	1033	1035	1033
query77	868	441	437	437
query78	10414	9076	9079	9076
query79	8851	572	563	563
query80	1263	626	630	626
query81	674	262	260	260
query82	794	167	163	163
query83	325	218	215	215
query84	293	108	100	100
query85	1495	365	355	355
query86	436	321	314	314
query87	4432	4386	4186	4186
query88	4792	2544	2562	2544
query89	554	331	328	328
query90	1982	239	242	239
query91	165	130	132	130
query92	89	76	75	75
query93	6769	568	560	560
query94	863	313	316	313
query95	394	295	297	295
query96	637	287	292	287
query97	3272	3084	3102	3084
query98	246	235	230	230
query99	1606	1330	1373	1330
Total cold run time: 321168 ms
Total hot run time: 191040 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.85 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a6109335d76a38850b6097ba1560200fc0633964, data reload: false

query1	0.05	0.05	0.04
query2	0.08	0.04	0.04
query3	0.23	0.06	0.06
query4	1.65	0.09	0.09
query5	0.52	0.51	0.51
query6	1.13	0.75	0.72
query7	0.02	0.01	0.02
query8	0.06	0.05	0.05
query9	0.56	0.47	0.49
query10	0.54	0.55	0.56
query11	0.16	0.12	0.12
query12	0.17	0.13	0.13
query13	0.64	0.59	0.60
query14	0.78	0.80	0.78
query15	0.84	0.82	0.82
query16	0.38	0.37	0.38
query17	1.04	1.00	0.99
query18	0.21	0.20	0.21
query19	1.81	1.74	1.83
query20	0.02	0.01	0.01
query21	15.42	0.66	0.66
query22	4.01	6.32	2.25
query23	18.26	1.32	1.33
query24	2.16	0.21	0.22
query25	0.15	0.08	0.09
query26	0.26	0.18	0.18
query27	0.08	0.09	0.08
query28	13.27	1.04	1.00
query29	12.64	5.70	5.68
query30	0.44	0.25	0.24
query31	2.82	0.40	0.40
query32	3.32	0.49	0.49
query33	3.01	2.96	2.99
query34	17.14	4.35	4.35
query35	4.39	4.45	4.42
query36	0.68	0.48	0.48
query37	0.22	0.18	0.17
query38	0.17	0.17	0.17
query39	0.07	0.06	0.06
query40	0.17	0.15	0.16
query41	0.12	0.07	0.07
query42	0.08	0.07	0.07
query43	0.07	0.07	0.07
Total cold run time: 109.84 s
Total hot run time: 33.85 s

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 21, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman morningman marked this pull request as ready for review August 21, 2024 07:48
@morningman
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 38399 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 131d6fa4d5f27d459539848f88c7b3749be8f51e, data reload: false

------ Round 1 ----------------------------------
q1	18267	4647	4456	4456
q2	2065	211	210	210
q3	11687	994	1111	994
q4	10519	726	736	726
q5	7801	2884	2854	2854
q6	268	161	160	160
q7	1030	668	652	652
q8	9620	2113	2145	2113
q9	8762	6566	6600	6566
q10	7048	2201	2196	2196
q11	484	267	271	267
q12	424	257	257	257
q13	18806	3015	3003	3003
q14	304	252	249	249
q15	558	506	528	506
q16	517	416	412	412
q17	1011	720	816	720
q18	7486	6849	6710	6710
q19	6938	1013	1090	1013
q20	710	356	355	355
q21	4535	2959	3028	2959
q22	1140	1062	1021	1021
Total cold run time: 119980 ms
Total hot run time: 38399 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4520	4325	4313	4313
q2	410	305	296	296
q3	2879	2715	2757	2715
q4	2026	1688	1720	1688
q5	5642	5683	5654	5654
q6	243	159	163	159
q7	2190	1778	1787	1778
q8	3299	3555	3452	3452
q9	8792	8814	8804	8804
q10	3611	3317	3294	3294
q11	614	539	533	533
q12	849	720	656	656
q13	17162	3070	3145	3070
q14	312	313	300	300
q15	576	534	520	520
q16	517	472	473	472
q17	1850	1535	1526	1526
q18	8336	7889	7774	7774
q19	3808	1735	1343	1343
q20	2171	1906	1905	1905
q21	13259	5354	5312	5312
q22	1182	1101	1096	1096
Total cold run time: 84248 ms
Total hot run time: 56660 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196469 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 131d6fa4d5f27d459539848f88c7b3749be8f51e, data reload: false

query1	1335	900	884	884
query2	6721	1992	1922	1922
query3	10698	3835	3832	3832
query4	56473	27957	23246	23246
query5	5595	668	661	661
query6	539	196	191	191
query7	6385	327	332	327
query8	552	441	442	441
query9	8748	2567	2533	2533
query10	550	350	341	341
query11	18022	15141	15461	15141
query12	208	142	141	141
query13	1684	469	472	469
query14	11188	7340	7397	7340
query15	236	203	194	194
query16	7387	544	569	544
query17	1190	624	626	624
query18	2042	344	347	344
query19	226	177	172	172
query20	151	138	141	138
query21	253	143	143	143
query22	4585	4346	4512	4346
query23	34089	33736	34027	33736
query24	5728	2974	2966	2966
query25	540	433	426	426
query26	741	192	183	183
query27	1813	303	309	303
query28	3711	2156	2151	2151
query29	688	443	449	443
query30	224	188	181	181
query31	995	840	823	823
query32	94	80	78	78
query33	519	350	339	339
query34	901	498	497	497
query35	859	761	750	750
query36	1073	933	978	933
query37	162	108	107	107
query38	3937	3856	3909	3856
query39	1533	1493	1473	1473
query40	238	156	157	156
query41	142	140	145	140
query42	141	120	117	117
query43	568	515	522	515
query44	1140	791	798	791
query45	224	194	194	194
query46	1135	806	783	783
query47	1926	1852	1890	1852
query48	425	330	339	330
query49	944	589	609	589
query50	866	464	472	464
query51	7137	7207	7107	7107
query52	118	112	111	111
query53	301	232	227	227
query54	612	509	520	509
query55	93	97	90	90
query56	340	317	315	315
query57	1199	1139	1130	1130
query58	304	306	308	306
query59	3149	2761	2900	2761
query60	346	340	334	334
query61	153	146	147	146
query62	791	691	710	691
query63	255	225	227	225
query64	2771	1871	1856	1856
query65	3296	3152	3180	3152
query66	1047	671	681	671
query67	15486	15044	14977	14977
query68	7222	579	577	577
query69	712	434	329	329
query70	1225	1129	1177	1129
query71	557	321	311	311
query72	6776	2358	2062	2062
query73	821	358	356	356
query74	9135	8893	8832	8832
query75	3989	2700	2753	2700
query76	3991	1030	1008	1008
query77	874	443	433	433
query78	9830	9298	9041	9041
query79	7141	555	557	555
query80	2292	602	620	602
query81	603	266	262	262
query82	924	159	157	157
query83	353	217	216	216
query84	303	97	95	95
query85	1089	355	354	354
query86	393	302	291	291
query87	4488	4314	4208	4208
query88	4734	2461	2448	2448
query89	540	330	328	328
query90	2104	229	233	229
query91	152	125	127	125
query92	83	75	76	75
query93	5683	542	545	542
query94	754	325	322	322
query95	389	299	292	292
query96	614	290	282	282
query97	3265	3042	3095	3042
query98	245	229	232	229
query99	1663	1349	1279	1279
Total cold run time: 330466 ms
Total hot run time: 196469 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.77 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 131d6fa4d5f27d459539848f88c7b3749be8f51e, data reload: false

query1	0.05	0.05	0.04
query2	0.07	0.04	0.04
query3	0.22	0.05	0.05
query4	1.73	0.07	0.09
query5	0.48	0.52	0.51
query6	1.13	0.73	0.73
query7	0.02	0.01	0.02
query8	0.06	0.05	0.05
query9	0.56	0.49	0.49
query10	0.56	0.55	0.56
query11	0.16	0.12	0.11
query12	0.16	0.14	0.13
query13	0.62	0.59	0.60
query14	0.76	0.79	0.78
query15	0.85	0.83	0.84
query16	0.38	0.38	0.38
query17	1.06	0.96	0.99
query18	0.21	0.22	0.21
query19	1.86	1.70	1.77
query20	0.02	0.01	0.01
query21	15.42	0.66	0.65
query22	4.81	7.07	1.66
query23	18.30	1.36	1.21
query24	2.13	0.23	0.22
query25	0.16	0.08	0.09
query26	0.28	0.18	0.19
query27	0.09	0.08	0.09
query28	13.28	1.03	1.00
query29	12.66	3.34	3.32
query30	0.43	0.24	0.24
query31	2.82	0.40	0.40
query32	3.24	0.49	0.50
query33	3.00	2.95	2.95
query34	17.15	4.35	4.37
query35	4.42	4.46	4.47
query36	0.68	0.50	0.50
query37	0.21	0.18	0.18
query38	0.17	0.16	0.19
query39	0.07	0.06	0.06
query40	0.19	0.15	0.15
query41	0.11	0.07	0.07
query42	0.07	0.06	0.07
query43	0.07	0.07	0.06
Total cold run time: 110.72 s
Total hot run time: 30.77 s

Copy link
Contributor

@kaka11chen kaka11chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit 70983f2 into apache:master Aug 21, 2024
28 of 30 checks passed
morningman pushed a commit to morningman/doris that referenced this pull request Aug 23, 2024
…#39663)

## Proposed changes

If the user has already registered, there is no need to register again,
otherwise `fs` will generate multiple instances.
morningman added a commit that referenced this pull request Aug 24, 2024
#39870)

bp #39663

Co-authored-by: wuwenchi <wuwenchihdu@hotmail.com>
dataroaring pushed a commit that referenced this pull request Aug 26, 2024
## Proposed changes

If the user has already registered, there is no need to register again,
otherwise `fs` will generate multiple instances.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.6-merged dev/3.0.2-merged p0_b reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants