[fix](mtmv) Fix result wrong when query rewrite by mv if query contains null_unsafe equals expression #39629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
TPC-H: Total hot run time: 38446 ms |
morrySnow
reviewed
Aug 20, 2024
| Map<Set<SlotReference>, Set<SlotReference>> equivalenceClassSetMap = new HashMap<>(); | ||
| List<Set<SlotReference>> sourceSets = source.getEquivalenceSetList(); | ||
| List<Set<SlotReference>> targetSets = target.getEquivalenceSetList(); | ||
| Map<List<SlotReference>, List<SlotReference>> equivalenceClassSetMap = new HashMap<>(); |
There was a problem hiding this comment.
why change set to list could fix this problem?
There was a problem hiding this comment.
such as the expression o_orderstatus = o_orderstatus we should compensate o_orderstatus = o_orderstatus on materialized view.
If we record the slot equal expression in set, only get {o_orderstatus}, in Predicates#compensateEquivalence we couldn't compensate filter.
Change set to list. we get {o_orderstatus, o_orderstatus}, then we can compensate filter by Predicates#compensateEquivalence .
…ns null_unsafe equals expression
seawinde
force-pushed
the
fix_null_unsafe_equals_result_wrong
branch
from
9ba2d25
to
1a6fb3c
Compare
|
run buildall |
TPC-H: Total hot run time: 37305 ms |
TPC-DS: Total hot run time: 191331 ms |
ClickBench: Total hot run time: 30.15 s |
starocean999
approved these changes
Aug 26, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
morrySnow
approved these changes
Aug 28, 2024
seawinde
added a commit
to seawinde/doris
that referenced
this pull request
Aug 28, 2024
…ns null_unsafe equals expression (apache#39629) Fix result wrong when query rewrite by mv if query contains null_unsafe equals expression and the expression both side is slot table orders data is as following: (null, 1, 'o', 9.5, '2023-12-08', 'a', 'b', 1, 'yy'), (1, null, 'o', 10.5, '2023-12-08', 'a', 'b', 1, 'yy'), (2, 1, null, 11.5, '2023-12-09', 'a', 'b', 1, 'yy'), (3, 1, 'o', null, '2023-12-10', 'a', 'b', 1, 'yy'), (3, 1, 'o', 33.5, null, 'a', 'b', 1, 'yy'), (4, 2, 'o', 43.2, '2023-12-11', null,'d',2, 'mm'), (5, 2, 'o', 56.2, '2023-12-12', 'c',null, 2, 'mi'), (5, 2, 'o', 1.2, '2023-12-12', 'c','d', null, 'mi'); such as mv def is select count(*), o_orderstatus, o_comment from orders group by o_orderstatus, o_comment; query is as following: select count(*), o_orderstatus, o_comment from orders where o_orderstatus = o_orderstatus group by o_orderstatus, o_comment; after rewrite by materialized view, the result is wrong as following, the row contains null should not appear +----------+---------------+-----------+ | count(*) | o_orderstatus | o_comment | +----------+---------------+-----------+ | 1 | NULL | yy | | 1 | o | mm | | 2 | o | mi | | 4 | o | yy | +----------+---------------+-----------+
yiguolei
pushed a commit
that referenced
this pull request
Aug 28, 2024
dataroaring
pushed a commit
that referenced
this pull request
Sep 3, 2024
…ns null_unsafe equals expression (#39629) Fix result wrong when query rewrite by mv if query contains null_unsafe equals expression and the expression both side is slot table orders data is as following: (null, 1, 'o', 9.5, '2023-12-08', 'a', 'b', 1, 'yy'), (1, null, 'o', 10.5, '2023-12-08', 'a', 'b', 1, 'yy'), (2, 1, null, 11.5, '2023-12-09', 'a', 'b', 1, 'yy'), (3, 1, 'o', null, '2023-12-10', 'a', 'b', 1, 'yy'), (3, 1, 'o', 33.5, null, 'a', 'b', 1, 'yy'), (4, 2, 'o', 43.2, '2023-12-11', null,'d',2, 'mm'), (5, 2, 'o', 56.2, '2023-12-12', 'c',null, 2, 'mi'), (5, 2, 'o', 1.2, '2023-12-12', 'c','d', null, 'mi'); such as mv def is select count(*), o_orderstatus, o_comment from orders group by o_orderstatus, o_comment; query is as following: select count(*), o_orderstatus, o_comment from orders where o_orderstatus = o_orderstatus group by o_orderstatus, o_comment; after rewrite by materialized view, the result is wrong as following, the row contains null should not appear +----------+---------------+-----------+ | count(*) | o_orderstatus | o_comment | +----------+---------------+-----------+ | 1 | NULL | yy | | 1 | o | mm | | 2 | o | mi | | 4 | o | yy | +----------+---------------+-----------+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix result wrong when query rewrite by mv if query contains null_unsafe equals expression and the expression both side is slot
table orders data is as following:
such as mv def is
query is as following:
after rewrite by materialized view, the result is wrong as following, the row contains null should not appear
the pr fix this