Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](group commit) fix group commit core if be inject FragmentMgr.exec_plan_fragment.failed (#39339) #39396

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

mymeiyi
Copy link
Contributor

@mymeiyi mymeiyi commented Aug 15, 2024

pick #39339

…ec_plan_fragment.failed (apache#39339)

```
*** SIGSEGV address not mapped to object (@0x0) received by PID 1898955 (TID 1900522 OR 0x7f4f94abc640) from PID 0; stack trace: ***
 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /home/zcp/repo_center/doris_branch-3.0.2-tmp/doris/be/src/common/signal_handler.h:421
 1# PosixSignals::chained_handler(int, siginfo*, void*) [clone .part.0] in /usr/lib/jvm/java-17-openjdk-amd64/lib/server/libjvm.so
 2# JVM_handle_linux_signal in /usr/lib/jvm/java-17-openjdk-amd64/lib/server/libjvm.so
 3# 0x00007F5335001520 in /lib/x86_64-linux-gnu/libc.so.6
 4# brpc::Socket::Write(brpc::SocketMessagePtr<void>&, brpc::Socket::WriteOptions const*) in /mnt/disk1/STRESS_ENV/be/lib/doris_be
 5# brpc::policy::HttpResponseSender::~HttpResponseSender() in /mnt/disk1/STRESS_ENV/be/lib/doris_be
 6# brpc::policy::HttpResponseSenderAsDone::~HttpResponseSenderAsDone() in /mnt/disk1/STRESS_ENV/be/lib/doris_be
 7# std::_Function_handler<void (), doris::PInternalService::group_commit_insert(google::protobuf::RpcController*, doris::PGroupCommitInsertRequest const*, doris::PGroupCommitInsertResponse*, google::protobuf::Closure*)::$_0>::_M_invoke(std::_Any_data const&) at /var/local/ldb-toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/std_function.h:291
 8# doris::WorkThreadPool<false>::work_thread(int) at /home/zcp/repo_center/doris_branch-3.0.2-tmp/doris/be/src/util/work_thread_pool.hpp:159
```
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Aug 15, 2024

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.52% (9319/25517)
Line Coverage: 28.01% (76349/272537)
Region Coverage: 26.82% (39220/146245)
Branch Coverage: 23.55% (19911/84556)
Coverage Report: http://coverage.selectdb-in.cc/coverage/18d549e29ac64823037e16ef584b40fadbd1813d_18d549e29ac64823037e16ef584b40fadbd1813d/report/index.html

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Aug 15, 2024

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.55% (9342/25562)
Line Coverage: 28.04% (76548/272968)
Region Coverage: 26.87% (39381/146557)
Branch Coverage: 23.60% (20007/84762)
Coverage Report: http://coverage.selectdb-in.cc/coverage/4d8d3d1c59137fac6d5ac8c309ef3d35d94f8d53_4d8d3d1c59137fac6d5ac8c309ef3d35d94f8d53/report/index.html

@dataroaring dataroaring merged commit fff26fe into apache:branch-2.1 Aug 15, 2024
19 of 21 checks passed
@yiguolei yiguolei mentioned this pull request Sep 5, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants