Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](Nereids) set operation output nullable maybe wrong #39109

Merged
merged 1 commit into from
Aug 9, 2024
Merged

[fix](Nereids) set operation output nullable maybe wrong #39109

merged 1 commit into from
Aug 9, 2024

Conversation

morrySnow
Copy link
Contributor

when first regulator child output nullable is not right, we may get wrong nullable output, and lead be crash

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@github-actions github-actions bot added the doing label Aug 8, 2024
@morrySnow
Copy link
Contributor Author

run buildall

@morrySnow
[fix](Nereids) set operation output nullable maybe wrong
fb45f72 
when first regulator child output nullable is not right, we may get
wrong nullable output, and lead be crash
@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39757 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit fb45f7226f88a8c18e3c0f1c43eb3525a1e34ab9, data reload: false

------ Round 1 ----------------------------------
q1	18134	4472	4432	4432
q2	2489	188	195	188
q3	11006	1145	1157	1145
q4	10669	735	729	729
q5	7769	2548	2549	2548
q6	232	142	140	140
q7	975	610	593	593
q8	9632	1916	1903	1903
q9	8841	6564	6574	6564
q10	7049	2229	2181	2181
q11	460	243	243	243
q12	396	219	217	217
q13	17769	2974	2981	2974
q14	270	234	236	234
q15	538	499	491	491
q16	504	390	390	390
q17	959	699	692	692
q18	8128	7470	7383	7383
q19	5229	1079	1088	1079
q20	657	328	344	328
q21	5233	4311	4397	4311
q22	1090	992	996	992
Total cold run time: 118029 ms
Total hot run time: 39757 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4466	4288	4303	4288
q2	385	286	272	272
q3	2844	2637	2595	2595
q4	1849	1563	1582	1563
q5	5250	5253	5269	5253
q6	216	132	134	132
q7	2047	1664	1698	1664
q8	3147	3356	3389	3356
q9	8464	8322	8429	8322
q10	3373	3163	3154	3154
q11	592	507	482	482
q12	776	569	604	569
q13	16557	2958	2986	2958
q14	307	279	278	278
q15	522	492	485	485
q16	478	417	407	407
q17	1766	1480	1474	1474
q18	7586	7550	7513	7513
q19	1664	1464	1519	1464
q20	2027	1821	1774	1774
q21	5277	4994	5049	4994
q22	1095	1004	985	985
Total cold run time: 70688 ms
Total hot run time: 53982 ms

@morrySnow
Copy link
Contributor Author

run cloud_p0

morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Aug 8, 2024
@morrySnow
[fix](Nereids) set operation output nullable maybe wrong (apache#39109)
3f650d2 
pick from master apache#39109

when first regulator child output nullable is not right, we may get
wrong nullable output, and lead be crash
@morrySnow morrySnow mentioned this pull request Aug 8, 2024
Merged
yiguolei pushed a commit that referenced this pull request Aug 8, 2024
@morrySnow
[fix](Nereids) set operation output nullable maybe wrong (#39109) (#3…
2244880 
…9129)

pick from master #39109

when first regulator child output nullable is not right, we may get
wrong nullable output, and lead be crash
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 9, 2024

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 9, 2024

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit 9e011c9 into apache:master Aug 9, 2024
29 of 30 checks passed
@morrySnow morrySnow deleted the fix_ser_operation_nullable branch August 9, 2024 07:21
dataroaring pushed a commit that referenced this pull request Aug 11, 2024
@morrySnow @dataroaring
[fix](Nereids) set operation output nullable maybe wrong (#39109)
b1ad113 
when first regulator child output nullable is not right, we may get
wrong nullable output, and lead be crash
wyxxxcat pushed a commit to wyxxxcat/doris that referenced this pull request Aug 14, 2024
@morrySnow @wyxxxcat
[fix](Nereids) set operation output nullable maybe wrong (apache#39109)
8b9084b 
when first regulator child output nullable is not right, we may get
wrong nullable output, and lead be crash
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Aug 15, 2024
@morrySnow
[fix](Nereids) set operation output nullable maybe wrong (apache#39109)
afe18b9 
pick from master apache#39109

when first regulator child output nullable is not right, we may get
wrong nullable output, and lead be crash
@morrySnow morrySnow mentioned this pull request Aug 15, 2024
Merged
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Aug 15, 2024
@morrySnow
[fix](Nereids) set operation output nullable maybe wrong (apache#39109)
d3fe8e7 
pick from master apache#39109

when first regulator child output nullable is not right, we may get
wrong nullable output, and lead be crash
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Aug 15, 2024
@morrySnow
[fix](Nereids) set operation output nullable maybe wrong (apache#39109)
7fdc902 
pick from master apache#39109

when first regulator child output nullable is not right, we may get
wrong nullable output, and lead be crash
dataroaring pushed a commit that referenced this pull request Aug 16, 2024
@morrySnow @dataroaring
[fix](Nereids) set operation output nullable maybe wrong (#39109)
fd0f66a 
when first regulator child output nullable is not right, we may get
wrong nullable output, and lead be crash
morrySnow added a commit that referenced this pull request Aug 16, 2024
@morrySnow
[fix](Nereids) set operation output nullable maybe wrong (#39109) (#3…
f247513 
…9444)

pick from master #39109

when first regulator child output nullable is not right, we may get
wrong nullable output, and lead be crash
@yiguolei yiguolei mentioned this pull request Sep 5, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starocean999 starocean999 starocean999 approved these changes

@feiniaofeiafei feiniaofeiafei feiniaofeiafei approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.15-merged dev/2.1.6-merged dev/3.0.2-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@morrySnow @doris-robot @starocean999 @feiniaofeiafei @yiguolei @dataroaring