Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](schema-change) Fix wrong intput column for cast validity check (#38894) #39107

Conversation

TangSiyang2001
Copy link
Collaborator

@TangSiyang2001 TangSiyang2001 commented Aug 8, 2024

Proposed changes

pick #38894

  1. Use column idx of ref block instead of new block to indicate the ref column.
  2. Rename some variables to clarify their meanings.
  3. Clarify some log msg.
  4. Add a minimal case to verify the change.

…pache#38894)

1. Use column idx of ref block instead of new block to indicate the ref
column.
2. Rename some variables to clarify their meanings.
3. Clarify some log msg.
4. Add a minimal case to verify the change.
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@TangSiyang2001
Copy link
Collaborator Author

run buildall

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/src/olap/schema_change.cpp Show resolved Hide resolved
@TangSiyang2001
Copy link
Collaborator Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.35% (9261/25474)
Line Coverage: 27.83% (75699/271960)
Region Coverage: 26.69% (38950/145911)
Branch Coverage: 23.41% (19761/84408)
Coverage Report: http://coverage.selectdb-in.cc/coverage/dd34564bf7cd22bd26a934b8b8f93cb3ccaf43ac_dd34564bf7cd22bd26a934b8b8f93cb3ccaf43ac/report/index.html

@dataroaring dataroaring merged commit f8f5be7 into apache:branch-2.1 Aug 8, 2024
20 of 22 checks passed
@yiguolei yiguolei mentioned this pull request Sep 5, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants