-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enhance](mtmv)hive cache add partitionId to partitionName Map #38525
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
TPC-H: Total hot run time: 41694 ms
|
TPC-DS: Total hot run time: 169944 ms
|
ClickBench: Total hot run time: 30.16 s
|
run buildall |
TPC-H: Total hot run time: 41738 ms
|
TPC-DS: Total hot run time: 169289 ms
|
ClickBench: Total hot run time: 30.9 s
|
run cloud_p0 |
fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HiveMetaStoreCache.java
Outdated
Show resolved
Hide resolved
run buildall |
TPC-H: Total hot run time: 41653 ms
|
TPC-DS: Total hot run time: 168314 ms
|
ClickBench: Total hot run time: 29.69 s
|
run p1 |
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…e#38525) MTMV need get partitionName by partitionId but now only have partitionName=>partitionId Map,when there are many partitions, obtaining the name from this map based on the ID can be slow,
…e#38525) MTMV need get partitionName by partitionId but now only have partitionName=>partitionId Map,when there are many partitions, obtaining the name from this map based on the ID can be slow,
MTMV need get partitionName by partitionId but now only have partitionName=>partitionId Map,when there are many partitions, obtaining the name from this map based on the ID can be slow,
Followup #38525 Previously, we use sequence number to generate partition id of table in hive metastore. for example, there are 2 partitions: `dt=2024-10-02` and `dt=2024-10-03`, the partition id will be 0 and 1. But if a new partition being added: `dt=2024-10-01`, the partiton id will be 0, 1, and 2. You can see, before, the id `0` is for `dt=2024-10-02`, but now `0` is for `dt=2024-10-01`. This PR use catalog/db/table/partition name to generate a id for the partition, so that each partition will have unique id.
Followup apache#38525 Previously, we use sequence number to generate partition id of table in hive metastore. for example, there are 2 partitions: `dt=2024-10-02` and `dt=2024-10-03`, the partition id will be 0 and 1. But if a new partition being added: `dt=2024-10-01`, the partiton id will be 0, 1, and 2. You can see, before, the id `0` is for `dt=2024-10-02`, but now `0` is for `dt=2024-10-01`. This PR use catalog/db/table/partition name to generate a id for the partition, so that each partition will have unique id.
Followup #38525 Previously, we use sequence number to generate partition id of table in hive metastore. for example, there are 2 partitions: `dt=2024-10-02` and `dt=2024-10-03`, the partition id will be 0 and 1. But if a new partition being added: `dt=2024-10-01`, the partiton id will be 0, 1, and 2. You can see, before, the id `0` is for `dt=2024-10-02`, but now `0` is for `dt=2024-10-01`. This PR use catalog/db/table/partition name to generate a id for the partition, so that each partition will have unique id.
MTMV need get partitionName by partitionId
but now only have partitionName=>partitionId Map,when there are many partitions, obtaining the name from this map based on the ID can be slow,