Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature](Recycler) Parallelize s3 delete operations and recycle_tablet #37630

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

ByteYue
Copy link
Contributor

@ByteYue ByteYue commented Jul 10, 2024

Proposed changes

Previously the procedure of recycler instance is single-threaded, which is not full sufficiently parallel. And there exists many network IO operation. So this pr tries to spilt recycle tasks into different stage which can be parallel. And make the delete operations parallel.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

cloud/src/recycler/obj_storage_client.cpp Show resolved Hide resolved
cloud/src/recycler/util.h Outdated Show resolved Hide resolved
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

cloud/test/recycler_test.cpp Show resolved Hide resolved
cloud/test/recycler_test.cpp Outdated Show resolved Hide resolved
@ByteYue
Copy link
Contributor Author

ByteYue commented Jul 12, 2024

run buildall

@ByteYue ByteYue changed the title [feature-wip](Recycler) Parallelize s3 delete operations and recycle_tablet [feature](Recycler) Parallelize s3 delete operations and recycle_tablet Jul 12, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

cloud/test/util_test.cpp Show resolved Hide resolved
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

cloud/test/util_test.cpp Show resolved Hide resolved
@ByteYue
Copy link
Contributor Author

ByteYue commented Jul 12, 2024

run buildall

@ByteYue
Copy link
Contributor Author

ByteYue commented Jul 15, 2024

run buildall

cloud/src/recycler/s3_accessor.h Outdated Show resolved Hide resolved
cloud/src/recycler/s3_accessor.cpp Outdated Show resolved Hide resolved
cloud/src/recycler/recycler.h Outdated Show resolved Hide resolved
cloud/src/recycler/util.h Outdated Show resolved Hide resolved
cloud/src/recycler/util.h Show resolved Hide resolved
cloud/src/recycler/obj_storage_client.h Outdated Show resolved Hide resolved
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

cloud/src/recycler/sync_executor.h Show resolved Hide resolved
cloud/src/recycler/util.h Show resolved Hide resolved
@ByteYue
Copy link
Contributor Author

ByteYue commented Jul 16, 2024

run buildall

@ByteYue
Copy link
Contributor Author

ByteYue commented Jul 16, 2024

run buildall

@ByteYue ByteYue force-pushed the batch_delete_for_recycler branch 4 times, most recently from 09d8af2 to f605509 Compare July 17, 2024 08:24
@ByteYue
Copy link
Contributor Author

ByteYue commented Jul 17, 2024

run buildall

@ByteYue
Copy link
Contributor Author

ByteYue commented Jul 18, 2024

run buildall

use atomic

use value
@ByteYue
Copy link
Contributor Author

ByteYue commented Jul 19, 2024

run buildall

Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jul 19, 2024
Copy link
Contributor

PR approved by anyone and no changes requested.

@gavinchou gavinchou merged commit 05b05bd into apache:master Jul 19, 2024
28 of 29 checks passed
dataroaring pushed a commit that referenced this pull request Aug 16, 2024
…et (#37630)

Previously the procedure of recycler instance is single-threaded, which
is not full sufficiently parallel. And there exists many network IO
operation. So this pr tries to spilt recycle tasks into different stage
which can be parallel. And make the delete operations parallel.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.2-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants