-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix](Nereids) fix fe fold constant evaluate like function #37616
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add ut and test case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was a mistake, fixed
@@ -0,0 +1,39 @@ | |||
-- This file is automatically generated. You should know what you did if you want to edit this | |||
-- !ds_shape_2 -- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should not in this pr?
@@ -405,6 +405,11 @@ public Expression visitOr(Or or, ExpressionRewriteContext context) { | |||
|
|||
@Override | |||
public Expression visitLike(Like like, ExpressionRewriteContext context) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe, it is better to just remove visitLike
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@@ -405,6 +405,11 @@ public Expression visitOr(Or or, ExpressionRewriteContext context) { | |||
|
|||
@Override | |||
public Expression visitLike(Like like, ExpressionRewriteContext context) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on 2.0, i think it's more important to investigate why c1 like '%xxx%' can't infer out c1 is not null by foldOnBe, than support like folding on fe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, but i think we can fix this problem first by adding this feature to fe folding constant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
3f6aa58
to
cb39156
Compare
run buildall |
cb39156
to
dda6f82
Compare
run buildall |
TPC-H: Total hot run time: 39787 ms
|
TPC-DS: Total hot run time: 174432 ms
|
ClickBench: Total hot run time: 30.22 s
|
run buildall |
TPC-H: Total hot run time: 39953 ms
|
TPC-DS: Total hot run time: 174231 ms
|
ClickBench: Total hot run time: 31.01 s
|
run external |
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
Problem: When evaluating like function using fe, it can not evaluating nullliteral correctly Example: Null like "%string%" can not folded to null on fe Reason: Fe fold constant does not deal with like function Solved: Add fe fold constant of like function
…pache#37616) (apache#37863) cherry-pick from master
Problem:
When evaluating like function using fe, it can not evaluating nullliteral correctly
Example:
Null like "%string%" can not folded to null on fe
Reason:
Fe fold constant does not deal with like function
Solved:
Add fe fold constant of like function