Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](meta-tool) Fix compile error in meta tool #31457

Merged
merged 1 commit into from
Feb 28, 2024
Merged

[fix](meta-tool) Fix compile error in meta tool #31457

merged 1 commit into from
Feb 28, 2024

Conversation

platoneko
Copy link
Contributor

Proposed changes

Fix compile error in meta tool

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

@platoneko
Copy link
Contributor Author

run buildall

@gavinchou
Copy link
Contributor

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@platoneko
Copy link
Contributor Author

run buildall

@platoneko
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

2 similar comments
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.70% (8545/23934)
Line Coverage: 27.51% (69351/252090)
Region Coverage: 26.65% (35954/134890)
Branch Coverage: 23.47% (18380/78320)
Coverage Report: http://coverage.selectdb-in.cc/coverage/24c7a30ddc8db802dbdd1852c0d7fd453e867841_24c7a30ddc8db802dbdd1852c0d7fd453e867841/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 37605 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 24c7a30ddc8db802dbdd1852c0d7fd453e867841, data reload: false

------ Round 1 ----------------------------------
q1	17705	4013	4022	4013
q2	2041	138	129	129
q3	10585	925	932	925
q4	4657	919	931	919
q5	7603	2822	2981	2822
q6	178	122	121	121
q7	1218	760	763	760
q8	9241	1984	1995	1984
q9	7145	6259	6229	6229
q10	8173	2497	2475	2475
q11	404	217	210	210
q12	766	309	308	308
q13	17953	3209	3201	3201
q14	282	273	238	238
q15	529	487	494	487
q16	469	396	402	396
q17	931	871	845	845
q18	6809	6121	5947	5947
q19	1547	1506	1510	1506
q20	543	279	276	276
q21	6916	3604	3540	3540
q22	794	281	274	274
Total cold run time: 106489 ms
Total hot run time: 37605 ms

----- Round 2, with runtime_filter_mode=off -----
q1	3984	4018	3967	3967
q2	300	220	215	215
q3	2965	2972	2912	2912
q4	1846	1784	1817	1784
q5	5080	5122	5094	5094
q6	201	115	115	115
q7	2122	1736	1683	1683
q8	3103	3173	3187	3173
q9	8194	8188	8166	8166
q10	6117	3665	3635	3635
q11	504	433	421	421
q12	690	517	506	506
q13	8574	3046	3045	3045
q14	285	254	255	254
q15	543	494	495	494
q16	494	476	443	443
q17	1676	1677	1661	1661
q18	7947	7456	7452	7452
q19	1638	1620	1622	1620
q20	2108	1915	1887	1887
q21	4804	4610	4651	4610
q22	519	470	449	449
Total cold run time: 63694 ms
Total hot run time: 53586 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 169392 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 24c7a30ddc8db802dbdd1852c0d7fd453e867841, data reload: false

query1	929	346	339	339
query2	6549	1738	1777	1738
query3	6706	208	203	203
query4	23363	20541	20576	20541
query5	4269	376	369	369
query6	262	183	169	169
query7	4615	313	307	307
query8	256	191	193	191
query9	8479	2296	2288	2288
query10	411	231	213	213
query11	14757	14141	14090	14090
query12	140	84	82	82
query13	1625	434	445	434
query14	8774	6850	6531	6531
query15	202	183	178	178
query16	7097	257	254	254
query17	1038	515	522	515
query18	1900	270	272	270
query19	192	146	150	146
query20	88	79	82	79
query21	194	119	116	116
query22	4722	4537	4579	4537
query23	30535	29897	29875	29875
query24	11831	3060	3096	3060
query25	655	377	355	355
query26	1788	154	166	154
query27	2988	314	309	309
query28	7011	1825	1828	1825
query29	1168	560	562	560
query30	287	133	144	133
query31	853	674	696	674
query32	98	62	58	58
query33	709	227	224	224
query34	1039	481	504	481
query35	843	755	775	755
query36	1000	842	861	842
query37	165	64	60	60
query38	3097	2977	2987	2977
query39	1328	1253	1256	1253
query40	280	110	102	102
query41	41	36	35	35
query42	108	96	101	96
query43	453	468	416	416
query44	1075	703	722	703
query45	190	178	174	174
query46	1070	821	800	800
query47	1516	1456	1437	1437
query48	424	355	356	355
query49	1150	310	296	296
query50	791	378	387	378
query51	4364	4335	4271	4271
query52	111	86	97	86
query53	339	270	264	264
query54	296	227	223	223
query55	82	83	81	81
query56	218	212	200	200
query57	952	892	903	892
query58	207	195	205	195
query59	2095	1990	2108	1990
query60	238	217	225	217
query61	85	84	86	84
query62	595	365	359	359
query63	285	255	255	255
query64	6619	2955	3139	2955
query65	3231	3219	3187	3187
query66	1433	319	312	312
query67	14383	14069	13932	13932
query68	5023	570	572	570
query69	553	385	403	385
query70	1270	1210	1206	1206
query71	356	260	252	252
query72	6209	2806	2648	2648
query73	727	322	320	320
query74	6319	6006	5956	5956
query75	3065	2482	2442	2442
query76	2812	1048	1161	1048
query77	349	242	230	230
query78	8963	8540	8507	8507
query79	1117	562	521	521
query80	736	350	352	350
query81	465	198	197	197
query82	1303	89	85	85
query83	214	123	122	122
query84	275	75	77	75
query85	1149	360	358	358
query86	320	293	298	293
query87	3274	3148	3081	3081
query88	2788	2356	2341	2341
query89	398	327	328	327
query90	2028	164	164	164
query91	153	120	126	120
query92	57	47	47	47
query93	1074	532	510	510
query94	1077	188	179	179
query95	445	340	353	340
query96	582	265	266	265
query97	4246	4133	4138	4133
query98	221	218	212	212
query99	1051	679	628	628
Total cold run time: 263213 ms
Total hot run time: 169392 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.44 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 24c7a30ddc8db802dbdd1852c0d7fd453e867841, data reload: false

query1	0.04	0.03	0.03
query2	0.06	0.02	0.02
query3	0.23	0.06	0.06
query4	1.64	0.09	0.10
query5	0.53	0.51	0.52
query6	1.31	0.67	0.67
query7	0.02	0.01	0.02
query8	0.03	0.02	0.02
query9	0.57	0.50	0.50
query10	0.56	0.56	0.56
query11	0.13	0.10	0.10
query12	0.12	0.10	0.11
query13	0.63	0.61	0.61
query14	0.81	0.80	0.79
query15	0.84	0.84	0.81
query16	0.39	0.37	0.37
query17	0.96	0.98	0.96
query18	0.26	0.25	0.25
query19	1.77	1.68	1.72
query20	0.01	0.02	0.02
query21	15.40	0.66	0.61
query22	3.48	3.83	2.78
query23	17.61	1.13	1.03
query24	2.17	0.28	0.29
query25	0.47	0.11	0.08
query26	0.17	0.16	0.16
query27	0.06	0.05	0.05
query28	12.16	0.85	0.84
query29	12.53	3.20	3.26
query30	0.65	0.58	0.52
query31	2.81	0.35	0.36
query32	3.33	0.48	0.48
query33	3.20	3.17	3.21
query34	15.36	4.75	4.73
query35	4.76	4.72	4.75
query36	1.14	1.07	1.06
query37	0.08	0.04	0.04
query38	0.04	0.02	0.02
query39	0.02	0.01	0.02
query40	0.20	0.13	0.12
query41	0.07	0.01	0.02
query42	0.02	0.02	0.01
query43	0.02	0.02	0.01
Total cold run time: 106.66 s
Total hot run time: 32.44 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 24c7a30ddc8db802dbdd1852c0d7fd453e867841 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select:       16.9 seconds inserted 10000000 Rows, about 591K ops/s

dataroaring
dataroaring approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 8dfb249 into apache:master Feb 28, 2024
26 of 28 checks passed
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

yiguolei pushed a commit that referenced this pull request Feb 29, 2024
@platoneko @Doris-Extras
[fix](meta-tool) Fix compile meta tool (#31457)
60de835
yiguolei pushed a commit that referenced this pull request Mar 4, 2024
@Doris-Extras
Revert "[fix](meta-tool) Fix compile meta tool (#31457)"
91efb6a 
This reverts commit 60de835.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavinchou gavinchou gavinchou approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@platoneko @doris-robot @gavinchou @dataroaring @xiaokang