Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](keyword) add BELONG as reserve keyword #31230

Merged
merged 2 commits into from
Feb 22, 2024
Merged

[fix](keyword) add BELONG as reserve keyword #31230

merged 2 commits into from
Feb 22, 2024

Conversation

morningman
Copy link
Contributor

Proposed changes

This #27994 introduce a new keyword BELONG, need to add it as reserve keyword

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

@morningman
Copy link
Contributor Author

run buildall

morrySnow
morrySnow previously approved these changes Feb 22, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman morningman mentioned this pull request Feb 22, 2024
Merged
@doris-robot
Copy link

TPC-H: Total hot run time: 41790 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4a3529f81a5d63e80c2821bd30bd02275758d2dd, data reload: false

------ Round 1 ----------------------------------
q1	18145	5281	5184	5184
q2	2970	145	140	140
q3	11066	1056	1015	1015
q4	5450	1020	1018	1018
q5	8189	3161	3228	3161
q6	204	137	134	134
q7	1250	790	777	777
q8	9244	2103	2081	2081
q9	7507	6658	6608	6608
q10	8325	2660	2672	2660
q11	422	218	218	218
q12	735	332	337	332
q13	17955	3623	3616	3616
q14	289	265	257	257
q15	594	508	501	501
q16	483	404	409	404
q17	931	894	898	894
q18	7370	6786	6661	6661
q19	1550	1506	1514	1506
q20	483	281	278	278
q21	6162	4046	4014	4014
q22	779	336	331	331
Total cold run time: 110103 ms
Total hot run time: 41790 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4925	4923	4885	4885
q2	293	191	190	190
q3	3601	3601	3606	3601
q4	2558	2537	2566	2537
q5	5768	5763	5743	5743
q6	215	131	133	131
q7	2237	1652	1662	1652
q8	3038	3109	3139	3109
q9	8723	8729	8708	8708
q10	6078	4260	4252	4252
q11	512	356	353	353
q12	770	539	542	539
q13	4230	3407	3428	3407
q14	276	243	225	225
q15	608	510	503	503
q16	488	439	435	435
q17	1678	1627	1619	1619
q18	8354	7710	7787	7710
q19	1662	1671	1672	1671
q20	2130	1834	1825	1825
q21	6603	6204	6163	6163
q22	562	506	475	475
Total cold run time: 65309 ms
Total hot run time: 59733 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 176188 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4a3529f81a5d63e80c2821bd30bd02275758d2dd, data reload: false

query1	916	357	347	347
query2	6503	1816	1712	1712
query3	6710	207	207	207
query4	23148	21101	21306	21101
query5	4298	370	369	369
query6	259	166	159	159
query7	4607	286	294	286
query8	253	200	200	200
query9	8436	2781	2769	2769
query10	421	229	224	224
query11	15025	14548	14415	14415
query12	135	85	81	81
query13	1696	428	415	415
query14	9059	7739	7629	7629
query15	212	189	190	189
query16	7424	251	246	246
query17	1425	540	521	521
query18	1932	262	264	262
query19	190	145	150	145
query20	83	78	86	78
query21	184	124	125	124
query22	4956	4664	4537	4537
query23	32452	31564	31607	31564
query24	12705	3382	3438	3382
query25	641	367	353	353
query26	1868	159	153	153
query27	3047	315	306	306
query28	6617	1845	1844	1844
query29	1176	622	611	611
query30	277	143	142	142
query31	951	744	755	744
query32	94	63	56	56
query33	729	240	235	235
query34	1063	480	494	480
query35	924	846	816	816
query36	993	897	870	870
query37	172	62	62	62
query38	3301	3213	3186	3186
query39	1355	1339	1310	1310
query40	285	103	103	103
query41	38	38	35	35
query42	108	99	96	96
query43	478	446	454	446
query44	1063	678	695	678
query45	197	189	176	176
query46	1045	763	749	749
query47	1686	1580	1558	1558
query48	415	344	345	344
query49	1208	302	299	299
query50	771	372	360	360
query51	4431	4280	4330	4280
query52	112	90	99	90
query53	398	302	299	299
query54	290	218	233	218
query55	87	81	85	81
query56	214	222	201	201
query57	1075	930	992	930
query58	224	189	189	189
query59	2247	2096	2231	2096
query60	237	217	226	217
query61	82	89	81	81
query62	592	378	400	378
query63	332	285	290	285
query64	6400	3031	3108	3031
query65	3291	3246	3258	3246
query66	1356	322	316	316
query67	14820	14209	14490	14209
query68	5127	571	544	544
query69	517	353	360	353
query70	1293	1230	1207	1207
query71	414	249	256	249
query72	6351	2774	2641	2641
query73	707	310	309	309
query74	6875	6492	6424	6424
query75	3369	2550	2557	2550
query76	3264	1125	1208	1125
query77	361	242	238	238
query78	9430	8756	8773	8756
query79	1001	522	512	512
query80	650	350	338	338
query81	437	203	204	203
query82	1149	85	87	85
query83	236	122	116	116
query84	222	79	76	76
query85	1148	361	330	330
query86	312	296	302	296
query87	3419	3284	3280	3280
query88	2670	2278	2274	2274
query89	438	353	354	353
query90	2022	161	165	161
query91	152	126	126	126
query92	56	51	47	47
query93	1032	518	500	500
query94	1092	180	177	177
query95	430	333	342	333
query96	571	265	267	265
query97	4448	4283	4273	4273
query98	217	208	198	198
query99	1103	731	728	728
Total cold run time: 270232 ms
Total hot run time: 176188 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.15 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4a3529f81a5d63e80c2821bd30bd02275758d2dd, data reload: false

query1	0.03	0.02	0.03
query2	0.06	0.02	0.02
query3	0.24	0.07	0.07
query4	1.62	0.08	0.09
query5	0.48	0.49	0.48
query6	1.41	0.61	0.63
query7	0.02	0.01	0.01
query8	0.04	0.02	0.02
query9	0.53	0.45	0.44
query10	0.47	0.47	0.48
query11	0.12	0.10	0.10
query12	0.12	0.10	0.10
query13	0.59	0.58	0.59
query14	0.75	0.78	0.80
query15	0.82	0.80	0.80
query16	0.33	0.33	0.33
query17	0.83	0.88	0.90
query18	0.16	0.17	0.15
query19	1.76	1.65	1.64
query20	0.01	0.01	0.02
query21	15.43	0.67	0.59
query22	2.76	4.18	2.65
query23	17.60	1.07	1.00
query24	2.21	0.28	0.31
query25	0.56	0.07	0.06
query26	0.16	0.14	0.15
query27	0.07	0.05	0.05
query28	12.08	0.84	0.83
query29	12.55	3.54	3.36
query30	0.50	0.51	0.45
query31	2.78	0.36	0.36
query32	3.32	0.48	0.48
query33	3.15	3.11	3.12
query34	15.33	4.46	4.47
query35	4.50	4.50	4.50
query36	1.07	0.94	0.94
query37	0.07	0.05	0.05
query38	0.04	0.03	0.03
query39	0.02	0.02	0.02
query40	0.17	0.15	0.17
query41	0.07	0.02	0.02
query42	0.03	0.01	0.02
query43	0.03	0.02	0.02
Total cold run time: 104.89 s
Total hot run time: 31.15 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 4a3529f81a5d63e80c2821bd30bd02275758d2dd with default session variables
Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select:       13.3 seconds inserted 10000000 Rows, about 751K ops/s

@morningman morningman mentioned this pull request Feb 22, 2024
Merged
morningman added a commit that referenced this pull request Feb 22, 2024
@morningman
[fix](keyword) add BELONG as reserve keyword (#31257)
d6bb15e 
introduced from #28165, bp #31230
@morningman
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Feb 22, 2024
@doris-robot
Copy link

TPC-H: Total hot run time: 41483 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d444041ab3885c715f7396817631dfe72a7b38ab, data reload: false

------ Round 1 ----------------------------------
q1	17627	5012	4887	4887
q2	2034	137	134	134
q3	10598	1033	978	978
q4	4735	974	963	963
q5	7662	3162	3166	3162
q6	201	130	131	130
q7	1243	780	770	770
q8	9891	2050	2027	2027
q9	7523	6623	6597	6597
q10	8356	2677	2667	2667
q11	411	223	216	216
q12	766	333	327	327
q13	17938	3639	3643	3639
q14	295	261	267	261
q15	628	522	538	522
q16	482	408	442	408
q17	919	862	822	822
q18	7452	6712	6902	6712
q19	1556	1494	1507	1494
q20	557	299	283	283
q21	6814	4106	4169	4106
q22	910	382	378	378
Total cold run time: 108598 ms
Total hot run time: 41483 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5572	5058	4955	4955
q2	303	184	185	184
q3	3674	3631	3579	3579
q4	2561	2596	2526	2526
q5	5869	5797	5808	5797
q6	210	128	122	122
q7	2254	1626	1644	1626
q8	3017	3097	3119	3097
q9	8751	8737	8672	8672
q10	6824	4215	4220	4215
q11	510	371	389	371
q12	770	538	548	538
q13	4236	3411	3370	3370
q14	257	237	238	237
q15	647	531	501	501
q16	498	443	440	440
q17	1671	1609	1615	1609
q18	8325	7656	7613	7613
q19	1618	1621	1626	1621
q20	2109	1847	1819	1819
q21	6611	6178	6153	6153
q22	552	490	497	490
Total cold run time: 66839 ms
Total hot run time: 59535 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 176744 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d444041ab3885c715f7396817631dfe72a7b38ab, data reload: false

query1	924	348	343	343
query2	6532	1866	1746	1746
query3	6702	207	197	197
query4	22980	21130	21230	21130
query5	4192	383	373	373
query6	260	169	168	168
query7	4625	299	289	289
query8	245	197	204	197
query9	8454	2776	2777	2776
query10	427	227	233	227
query11	15097	14518	14356	14356
query12	139	83	82	82
query13	1709	428	426	426
query14	9398	7664	7626	7626
query15	213	193	199	193
query16	7537	260	251	251
query17	1422	548	529	529
query18	1948	274	273	273
query19	198	148	150	148
query20	87	82	85	82
query21	186	127	124	124
query22	4957	4763	4779	4763
query23	32354	31532	31540	31532
query24	12497	3400	3285	3285
query25	640	365	353	353
query26	1883	150	164	150
query27	3060	313	312	312
query28	6721	1859	1835	1835
query29	1116	635	624	624
query30	282	138	150	138
query31	949	757	756	756
query32	92	61	56	56
query33	726	242	232	232
query34	1040	496	508	496
query35	948	830	818	818
query36	1014	926	865	865
query37	154	61	62	61
query38	3341	3214	3181	3181
query39	1382	1338	1313	1313
query40	282	111	106	106
query41	37	34	35	34
query42	106	103	100	100
query43	472	438	438	438
query44	1066	689	705	689
query45	195	179	178	178
query46	1032	789	788	788
query47	1619	1537	1564	1537
query48	427	353	347	347
query49	1222	308	319	308
query50	772	368	367	367
query51	4506	4354	4387	4354
query52	109	96	86	86
query53	395	300	296	296
query54	295	221	239	221
query55	82	80	90	80
query56	221	197	204	197
query57	1001	926	963	926
query58	208	203	196	196
query59	2214	2251	2164	2164
query60	243	221	227	221
query61	86	85	88	85
query62	589	401	378	378
query63	314	285	292	285
query64	6463	3068	3113	3068
query65	3278	3277	3237	3237
query66	1347	328	325	325
query67	14451	14445	14257	14257
query68	5090	564	576	564
query69	503	375	366	366
query70	1273	1212	1203	1203
query71	372	258	255	255
query72	6339	2780	2683	2683
query73	712	310	311	310
query74	6941	6450	6436	6436
query75	3169	2584	2556	2556
query76	3110	1096	1197	1096
query77	338	241	232	232
query78	9410	8787	8843	8787
query79	1091	522	502	502
query80	853	362	344	344
query81	451	203	205	203
query82	1232	89	83	83
query83	198	128	122	122
query84	227	80	77	77
query85	1195	363	361	361
query86	308	312	325	312
query87	3503	3278	3305	3278
query88	2679	2277	2280	2277
query89	436	352	352	352
query90	2146	166	161	161
query91	157	129	130	129
query92	54	46	51	46
query93	1037	522	500	500
query94	1169	181	178	178
query95	431	332	348	332
query96	571	268	262	262
query97	4466	4268	4318	4268
query98	219	202	201	201
query99	1103	736	694	694
Total cold run time: 270246 ms
Total hot run time: 176744 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.35 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d444041ab3885c715f7396817631dfe72a7b38ab, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.03	0.03
query3	0.22	0.08	0.08
query4	1.64	0.08	0.08
query5	0.49	0.49	0.48
query6	1.38	0.61	0.62
query7	0.02	0.01	0.01
query8	0.04	0.02	0.02
query9	0.53	0.46	0.45
query10	0.49	0.48	0.50
query11	0.12	0.09	0.09
query12	0.12	0.10	0.10
query13	0.60	0.60	0.59
query14	0.77	0.79	0.80
query15	0.82	0.79	0.80
query16	0.32	0.33	0.34
query17	0.93	0.92	0.93
query18	0.20	0.19	0.16
query19	1.72	1.68	1.71
query20	0.01	0.01	0.02
query21	15.42	0.67	0.60
query22	3.11	3.99	2.75
query23	17.30	0.94	0.93
query24	1.97	0.78	0.20
query25	0.63	0.06	0.05
query26	0.16	0.14	0.13
query27	0.04	0.06	0.04
query28	12.00	0.79	0.80
query29	12.51	3.37	3.42
query30	0.52	0.49	0.49
query31	2.77	0.38	0.36
query32	3.35	0.48	0.48
query33	3.13	3.14	3.14
query34	15.38	4.54	4.53
query35	4.51	4.55	4.49
query36	1.07	0.99	0.98
query37	0.07	0.06	0.05
query38	0.04	0.03	0.03
query39	0.02	0.02	0.02
query40	0.17	0.14	0.14
query41	0.07	0.02	0.02
query42	0.02	0.02	0.01
query43	0.03	0.02	0.02
Total cold run time: 104.82 s
Total hot run time: 31.35 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit d444041ab3885c715f7396817631dfe72a7b38ab with default session variables
Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc:          60 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select:       13.5 seconds inserted 10000000 Rows, about 740K ops/s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@morningman morningman merged commit 07162c4 into apache:master Feb 22, 2024
27 of 29 checks passed
yiguolei pushed a commit that referenced this pull request Feb 22, 2024
@morningman @Doris-Extras
[fix](keyword) add BELONG as reserve keyword (#31230)
a5ee1b3 
This #27994 introduce a new keyword BELONG, need to add it as reserve keyword
morningman added a commit that referenced this pull request Feb 22, 2024
@morningman
[feature](analyze_cmd) add show-tablets-belong stmt for analyzing a b…
762820d 
…atch of tablet-ids (#27994) (#31255)

bp #27994 #31230
feiniaofeiafei pushed a commit to feiniaofeiafei/doris that referenced this pull request Feb 23, 2024
@morningman @feiniaofeiafei
[fix](keyword) add BELONG as reserve keyword (apache#31230)
d0667be 
This apache#27994 introduce a new keyword BELONG, need to add it as reserve keyword
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@morningman
[feature](analyze_cmd) add show-tablets-belong stmt for analyzing a b…
b1f0725 
…atch of tablet-ids (apache#27994) (apache#31255)

bp apache#27994 apache#31230
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Doris-Extras Doris-Extras Doris-Extras approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/1.2.8-merged dev/2.0.5-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@morningman @doris-robot @Doris-Extras @morrySnow