Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] (schema change) forbid adding time type column #28751

Merged
merged 1 commit into from
Dec 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -951,6 +951,10 @@ private boolean addColumnInternal(OlapTable olapTable, Column newColumn, ColumnP
}
}

if (newColumn.getType().isTime() || newColumn.getType().isTimeV2()) {
throw new DdlException("Time type is not supported for olap table");
}

// hll must be used in agg_keys
if (newColumn.getType().isHllType() && KeysType.AGG_KEYS != olapTable.getKeysType()) {
throw new DdlException("HLL type column can only be in Aggregation data model table: " + newColName);
Expand Down
55 changes: 55 additions & 0 deletions regression-test/suites/schema_change_p0/check_time_type.groovy
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

suite("check_time_type", "p0") {
def tableName = "check_time_type"

sql """
drop table IF exists ${tableName}
"""

sql """
CREATE TABLE ${tableName}
(
k1 INT,
k2 int,
v1 INT,
v2 INT,
v3 varchar(32)
)
UNIQUE KEY (k1, k2)
DISTRIBUTED BY HASH(k2) BUCKETS 1
PROPERTIES (
'light_schema_change' = 'true',
'replication_num' = '1'
)
"""

sql """
insert into ${tableName} values (1, 2, 3, 4, 'a');
"""

test {
sql """ alter table ${tableName} add column new_col time """
exception "errCode = 2, detailMessage = Time type is not supported for olap table"
}

sql """
select * from ${tableName}
"""
}

Loading