-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](pipeline) Fix query is not cancelled when be report error status #28669
Conversation
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
This fix is a subset of pr #23142
|
TeamCity be ut coverage result: |
13c8ccc
to
9da28ef
Compare
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
TeamCity be ut coverage result: |
(From new machine)TeamCity pipeline, clickbench performance test result: |
9da28ef
to
9c4e160
Compare
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
TeamCity be ut coverage result: |
(From new machine)TeamCity pipeline, clickbench performance test result: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
FE will return empty set instead of error, if:
This pr fix above problem on branch-2.0 by:
PS: Maybe the fix is not perfect ... but it works with almost least modification. A complete fix needs almost a refactor on DataExchangeNode.