Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seek block when starts a ScanKey #1828

Merged
merged 4 commits into from
Sep 19, 2019
Merged

Seek block when starts a ScanKey #1828

merged 4 commits into from
Sep 19, 2019

Conversation

chaoyli
Copy link
Contributor

@chaoyli chaoyli commented Sep 19, 2019

In Doris, one block has 1024 rows.

  1. If the previous ScanKey scan rows multiple blocks,
    and also the final block has 1024 rows just right.
  2. The current ScanKey scan rows with number less than one block.
    Under the two conditions, if not seek block, the position of prefix shortkey columns is wrong.

chaoyli added 2 commits September 19, 2019 12:53
In Doris, one block has 1024 rows.
1. If the previous ScanKey scan rows multiple blocks,
   and also the final block has 1024 rows just right.
2. The current ScanKey scan rows with number less than one block.
Under the two conditions, if not seek block, the position of prefix shortkey columns is wrong.
be/src/olap/rowset/segment_reader.h Outdated Show resolved Hide resolved
be/src/olap/rowset/segment_reader.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@imay imay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chaoyli chaoyli closed this Sep 19, 2019
@chaoyli chaoyli reopened this Sep 19, 2019
@chaoyli chaoyli merged commit 315f762 into apache:master Sep 19, 2019
chaoyli pushed a commit to baidu-doris/incubator-doris that referenced this pull request Sep 19, 2019
Seek block when starts a ScanKey (apache#1828)
@imay imay mentioned this pull request Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants