-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve](Nereids): Add all slots used by onClause in project #12701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morrySnow
approved these changes
Sep 19, 2022
github-actions
bot
added
the
approved
Indicates a PR has been approved by one committer.
label
Sep 19, 2022
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
FreeOnePlus
pushed a commit
to FreeOnePlus/doris
that referenced
this pull request
Oct 8, 2022
…rder and fix reorder mark (apache#12701) 1. Add all slots used by onClause in project ``` (A & B) & C like join(hash conjuncts: C.t2 = A.t2) |---project(A.t2) | +---join(hash conjuncts: A.t1 = B.t1) | +---A | +---B +---C transform to (A & C) & B join(hash conjuncts: A.t1 = B.t1) |---project(A.t2) | +---join(hash conjuncts: C.t2 = A.t2) | +---A | +---C +---B ``` But projection just include `A.t2`, can't find `A.t1`, we should add slots used by onClause when projection exist. 2. fix join reorder mark Add mark `LAsscom` when apply `LAsscom` 3. remove slotReference use `Slot` instead of `SlotReference` to avoid cast.
FreeOnePlus
pushed a commit
to FreeOnePlus/doris
that referenced
this pull request
Oct 8, 2022
…rder and fix reorder mark (apache#12701) 1. Add all slots used by onClause in project ``` (A & B) & C like join(hash conjuncts: C.t2 = A.t2) |---project(A.t2) | +---join(hash conjuncts: A.t1 = B.t1) | +---A | +---B +---C transform to (A & C) & B join(hash conjuncts: A.t1 = B.t1) |---project(A.t2) | +---join(hash conjuncts: C.t2 = A.t2) | +---A | +---C +---B ``` But projection just include `A.t2`, can't find `A.t1`, we should add slots used by onClause when projection exist. 2. fix join reorder mark Add mark `LAsscom` when apply `LAsscom` 3. remove slotReference use `Slot` instead of `SlotReference` to avoid cast.
FreeOnePlus
pushed a commit
to FreeOnePlus/doris
that referenced
this pull request
Oct 8, 2022
…rder and fix reorder mark (apache#12701) 1. Add all slots used by onClause in project ``` (A & B) & C like join(hash conjuncts: C.t2 = A.t2) |---project(A.t2) | +---join(hash conjuncts: A.t1 = B.t1) | +---A | +---B +---C transform to (A & C) & B join(hash conjuncts: A.t1 = B.t1) |---project(A.t2) | +---join(hash conjuncts: C.t2 = A.t2) | +---A | +---C +---B ``` But projection just include `A.t2`, can't find `A.t1`, we should add slots used by onClause when projection exist. 2. fix join reorder mark Add mark `LAsscom` when apply `LAsscom` 3. remove slotReference use `Slot` instead of `SlotReference` to avoid cast.
FreeOnePlus
pushed a commit
to FreeOnePlus/doris
that referenced
this pull request
Oct 8, 2022
…rder and fix reorder mark (apache#12701) 1. Add all slots used by onClause in project ``` (A & B) & C like join(hash conjuncts: C.t2 = A.t2) |---project(A.t2) | +---join(hash conjuncts: A.t1 = B.t1) | +---A | +---B +---C transform to (A & C) & B join(hash conjuncts: A.t1 = B.t1) |---project(A.t2) | +---join(hash conjuncts: C.t2 = A.t2) | +---A | +---C +---B ``` But projection just include `A.t2`, can't find `A.t1`, we should add slots used by onClause when projection exist. 2. fix join reorder mark Add mark `LAsscom` when apply `LAsscom` 3. remove slotReference use `Slot` instead of `SlotReference` to avoid cast.
FreeOnePlus
pushed a commit
to FreeOnePlus/doris
that referenced
this pull request
Oct 8, 2022
…rder and fix reorder mark (apache#12701) 1. Add all slots used by onClause in project ``` (A & B) & C like join(hash conjuncts: C.t2 = A.t2) |---project(A.t2) | +---join(hash conjuncts: A.t1 = B.t1) | +---A | +---B +---C transform to (A & C) & B join(hash conjuncts: A.t1 = B.t1) |---project(A.t2) | +---join(hash conjuncts: C.t2 = A.t2) | +---A | +---C +---B ``` But projection just include `A.t2`, can't find `A.t1`, we should add slots used by onClause when projection exist. 2. fix join reorder mark Add mark `LAsscom` when apply `LAsscom` 3. remove slotReference use `Slot` instead of `SlotReference` to avoid cast.
FreeOnePlus
pushed a commit
to FreeOnePlus/doris
that referenced
this pull request
Oct 8, 2022
…rder and fix reorder mark (apache#12701) 1. Add all slots used by onClause in project ``` (A & B) & C like join(hash conjuncts: C.t2 = A.t2) |---project(A.t2) | +---join(hash conjuncts: A.t1 = B.t1) | +---A | +---B +---C transform to (A & C) & B join(hash conjuncts: A.t1 = B.t1) |---project(A.t2) | +---join(hash conjuncts: C.t2 = A.t2) | +---A | +---C +---B ``` But projection just include `A.t2`, can't find `A.t1`, we should add slots used by onClause when projection exist. 2. fix join reorder mark Add mark `LAsscom` when apply `LAsscom` 3. remove slotReference use `Slot` instead of `SlotReference` to avoid cast.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem summary
But projection just include
A.t2
, can't findA.t1
, we should add slots used by onClause when projection exist.Add mark
LAsscom
when applyLAsscom
use
Slot
instead ofSlotReference
to avoid cast.Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...