Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix](stack_over_flow) fix be may core dump because of stack-buffer-overflow when TBrokerOpenReaderResponse too large #12658

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

yangzhg
Copy link
Member

@yangzhg yangzhg commented Sep 16, 2022

Proposed changes

Issue Number: close #12654

Problem summary

be may core dump because of stack-buffer-overflow when TBrokerOpenReaderResponse too large

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

…r-overflow when TBrokerOpenReaderResponse too large
Copy link
Contributor

@cambyzju cambyzju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 16, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit b733a23 into apache:master Sep 16, 2022
@dataroaring
Copy link
Contributor

Could we add a regression test ?

morningman pushed a commit that referenced this pull request Sep 21, 2022
…r-overflow when TBrokerOpenReaderResponse too large (#12658)
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
…r-overflow when TBrokerOpenReaderResponse too large (apache#12658)
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
…r-overflow when TBrokerOpenReaderResponse too large (apache#12658)
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
…r-overflow when TBrokerOpenReaderResponse too large (apache#12658)
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
…r-overflow when TBrokerOpenReaderResponse too large (apache#12658)
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
…r-overflow when TBrokerOpenReaderResponse too large (apache#12658)
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
…r-overflow when TBrokerOpenReaderResponse too large (apache#12658)
@yiguolei yiguolei mentioned this pull request Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/merged-1.1.3-deprecated reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] be may core dump because of stack-buffer-overflow when TBrokerOpenReaderResponse too large
5 participants