[enhancement](memtracker) Optimize query memory accuracy #11740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiguolei
reviewed
Aug 12, 2022
yiguolei
reviewed
Aug 12, 2022
xinyiZzz
force-pushed
the
mem_tracker_factor_v2_fix8_push
branch
from
addbcda
to
dd54cb5
Compare
5 tasks
yiguolei
pushed a commit
that referenced
this pull request
Mar 26, 2023
#11740 , solved the problem that the query memory statistics are higher than the actual physical memory, because PODArray does not have memset 0 when allocating memory, and the query mem tracker is virtual memory. But in extreme cases, such as csv load, PODArray frequent insert will cause performance problems. So revert part of #11740 and part of #12820. The accuracy of the query mem tracker, there is currently no feedback, no further attention.
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 21, 2023
…8010 apache#11740 , solved the problem that the query memory statistics are higher than the actual physical memory, because PODArray does not have memset 0 when allocating memory, and the query mem tracker is virtual memory. But in extreme cases, such as csv load, PODArray frequent insert will cause performance problems. So revert part of apache#11740 and part of apache#12820. The accuracy of the query mem tracker, there is currently no feedback, no further attention.
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Jul 12, 2023
…8010 apache#11740 , solved the problem that the query memory statistics are higher than the actual physical memory, because PODArray does not have memset 0 when allocating memory, and the query mem tracker is virtual memory. But in extreme cases, such as csv load, PODArray frequent insert will cause performance problems. So revert part of apache#11740 and part of apache#12820. The accuracy of the query mem tracker, there is currently no feedback, no further attention.
xinyiZzz
added a commit
to xinyiZzz/incubator-doris
that referenced
this pull request
Jul 28, 2023
…8010 apache#11740 , solved the problem that the query memory statistics are higher than the actual physical memory, because PODArray does not have memset 0 when allocating memory, and the query mem tracker is virtual memory. But in extreme cases, such as csv load, PODArray frequent insert will cause performance problems. So revert part of apache#11740 and part of apache#12820. The accuracy of the query mem tracker, there is currently no feedback, no further attention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #11738
Problem summary
motivation
The value of the query mem tracker is consistent with the physical memory actually used by the query.
problem causes
Currently, only the virtual memory used by the query can be tracked through the tcmalloc hook. When the memory is not fully used after the application, the recorded virtual memory will be larger than the physical memory.
At present, it is mainly because PODArray does not memset 0 when applying for memory, and blocks applied for through PODArray in places such as VOlapScanNode::_free_blocks are usually used for memory reuse and cannot be fully used.
Fix
The query mem tracker only records the peak memory used by PODArray and MemPool
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...