Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](planner)unnecessary cast will be added on children in InPredicate #11033

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

morrySnow
Copy link
Contributor

Proposed changes

Issue Number: close #10881

Problem Summary:

We should use equals function rather than Use equals operator to compare two Type in Analyzer#castAllToCompatibleType.

Checklist(Required)

  1. Does it affect the original behavior: No
  2. Has unit tests been added: No
  3. Has document been added or modified: No
  4. Does it need to update dependencies:No
  5. Are there any changes that cannot be rolled back: No

Further comments

@github-actions github-actions bot added the area/planner Issues or PRs related to the query planner label Jul 20, 2022
@morrySnow
Copy link
Contributor Author

@EmmyMiao87 @morningman PTAL

Copy link

@kpfly kpfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@dataalive dataalive added this to the V1.1.1 milestone Jul 20, 2022
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 658a9f7 into apache:master Jul 20, 2022
yiguolei pushed a commit to yiguolei/incubator-doris that referenced this pull request Jul 20, 2022
yiguolei added a commit that referenced this pull request Jul 20, 2022
… in InPredicate (#11033) (#11036)

Co-authored-by: morrySnow <101034200+morrySnow@users.noreply.github.com>
@kkfnui kkfnui mentioned this pull request Jul 22, 2022
@kpfly kpfly mentioned this pull request Jul 25, 2022
3 tasks
@morrySnow morrySnow deleted the fixcastAllToCompatibleType branch July 25, 2022 03:14
miswujian pushed a commit to miswujian/doris that referenced this pull request Jul 28, 2022
whutpencil pushed a commit to whutpencil/incubator-doris that referenced this pull request Jul 29, 2022
eldenmoon pushed a commit to eldenmoon/incubator-doris that referenced this pull request Aug 1, 2022
Henry2SS pushed a commit to Henry2SS/incubator-doris that referenced this pull request Sep 14, 2022
… in InPredicate (apache#11033) (apache#11036)

Co-authored-by: morrySnow <101034200+morrySnow@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/planner Issues or PRs related to the query planner dev/merge-1.1.1 reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] With in in select smt and group by will cause missing from GROUP BY
4 participants