[refactor] (Nereids) rename GroupExpression.getParent() to getOwnerGroup() #11027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please use |
924060929
reviewed
Jul 20, 2022
| // TODO: need to merge group recursively | ||
| groupExpression.getParent().removeGroupExpression(groupExpression); | ||
| GroupExpression that = groupExpressions.get(groupExpression); | ||
| mergeGroup(groupExpression.getOwnerGroup(), that.getOwnerGroup()); |
There was a problem hiding this comment.
we should add some ut for merge group recursively
|
wait for checks |
924060929
changed the title
englefly
changed the title
jackwener
approved these changes
Jul 20, 2022
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
miswujian
pushed a commit
to miswujian/doris
that referenced
this pull request
Jul 28, 2022
…oup() (apache#11027) GroupExpression.getParent() returns the group which contains this expr. This name is missleading especially in tree structures. So we change the name to getOwnerGroup.
whutpencil
pushed a commit
to whutpencil/incubator-doris
that referenced
this pull request
Jul 29, 2022
…oup() (apache#11027) GroupExpression.getParent() returns the group which contains this expr. This name is missleading especially in tree structures. So we change the name to getOwnerGroup.
eldenmoon
pushed a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Aug 1, 2022
…oup() (apache#11027) GroupExpression.getParent() returns the group which contains this expr. This name is missleading especially in tree structures. So we change the name to getOwnerGroup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
GroupExpression.getParent() returns the group which contains this expr. This name is missleading especially in tree structures.
So we change the name to getOwnerGroup.
@924060929 could u review, please?
Issue Number: close #xxx
Problem Summary:
Describe the overview of changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...