Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gradle args cdvBuildToolsVersion is not correctly honoured #1290

Closed
3 tasks done
breautek opened this issue Jul 23, 2021 · 4 comments · Fixed by #1293
Closed
3 tasks done

gradle args cdvBuildToolsVersion is not correctly honoured #1290

breautek opened this issue Jul 23, 2021 · 4 comments · Fixed by #1293
Labels
Milestone

Comments

@breautek
Copy link
Contributor

breautek commented Jul 23, 2021

Bug Report

Problem

What is expected to happen?

It is expected for Cordova use the specified build tools version via cdvBuildToolsVersion gradle parameter if the parameter is defined.

What does actually happen?

Cordova does use it, but now passes it through findLatestInstalledBuildTools call, effectively turning the parameter into a "minimum build tools version" parameter instead of a "build tools version" parameter.

Information

This behaviour changed from cordova-android@9.1 where if cdvBuildToolsVersion was defined, it will simply use it. See 9.1

Further investigation notes are written: #1288 (comment) where this issue was first identified.

Command or Code

Have build tools version 30 & 31 installed. Building Build tools version 31 as described here

Then run: cordova build android --release -- --gradleArg=-PcdvBuildToolsVersion=30.0.3

It is expected that cordova will use build tools version 30.0.3 instead of build tools 31.

Environment, Platform, Device

Android

Version information

cordova-android@10

Checklist

  • I searched for existing GitHub issues
  • I updated all Cordova tooling to most recent version
  • I included all the necessary information above
@gopi-hl
Copy link

gopi-hl commented Jul 23, 2021

This seems to have been addressed in 10.0.0.

#659 (comment)

@breautek
Copy link
Contributor Author

This seems to have been addressed in 10.0.0.

#659 (comment)

That is unrelated.

The comment you referenced is in response to an issue where cdvBuildToolsVersion is not defined.

This issue is when cdvBuildToolsVersion is defined, but Cordova still decides to choose the latest installed anyway.

@EinfachHans
Copy link
Contributor

Can someone publish 10.0.1 to npm?

@breautek
Copy link
Contributor Author

It's currently in the apache voting process

https://www.apache.org/foundation/voting.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants