Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a data corruption known issue to CHANGES.md and release blogs. #32166

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

shunping
Copy link
Contributor

@shunping shunping commented Aug 13, 2024

This is a follow-up PR to add the GCS data corruption as a known issue in the release notes.

Previous PR: #32135.
Primary Bug: #32169.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@shunping
Copy link
Contributor Author

r: @jrmccluskey @damccorm

Copy link
Contributor

@jrmccluskey jrmccluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@jrmccluskey
Copy link
Contributor

Waiting on precommits to finish before merging

@shunping shunping marked this pull request as draft August 13, 2024 15:17
@shunping
Copy link
Contributor Author

Converting this to draft for now as I am going to add a new bug to document the issue. Will reference the bug in the release notes.

@shunping shunping marked this pull request as ready for review August 13, 2024 17:44
@shunping
Copy link
Contributor Author

@jrmccluskey: PTAL. Thanks!

Copy link
Contributor

@jrmccluskey jrmccluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrmccluskey jrmccluskey merged commit ab81e1f into apache:master Aug 13, 2024
6 checks passed
@shunping shunping deleted the update-known-issue branch August 28, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants