Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JobServerOption for --jar_cache_dir #32033

Open
wants to merge 27 commits into
base: master
Choose a base branch
from

Conversation

s21lee
Copy link

@s21lee s21lee commented Jul 31, 2024

Please add a meaningful description for your change here

Pass custom cache dir to prevent
PermissionError: [Errno 13] Permission denied: '/home/.apache_beam'


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Signed-off-by: s21.lee <s21.lee@samsung.com>
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change! Overall, this looks like a good change to me, would you mind taking a look at the failing precommits and make sure the code is at least passing most of those and compiling? It looks like there are some issues with the test code

s21.lee and others added 4 commits August 22, 2024 14:53
- add missing comma

Signed-off-by: s21.lee <s21.lee@samsung.com>
Signed-off-by: s21lee <lsh41777@gmail.com>
Signed-off-by: s21lee <lsh41777@gmail.com>
Signed-off-by: s21lee <lsh41777@gmail.com>
s21lee and others added 5 commits August 27, 2024 13:29
Signed-off-by: s21lee <lsh41777@gmail.com>
Signed-off-by: s21lee <lsh41777@gmail.com>
Signed-off-by: s21lee <lsh41777@gmail.com>
Signed-off-by: s21lee <lsh41777@gmail.com>
s21lee and others added 3 commits August 29, 2024 11:50
Signed-off-by: s21lee <lsh41777@gmail.com>
Signed-off-by: s21lee <lsh41777@gmail.com>
Copy link
Contributor

github-actions bot commented Sep 5, 2024

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @tvalentyn for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@tvalentyn
Copy link
Contributor

waiting on author

Signed-off-by: s21lee <lsh41777@gmail.com>
@github-actions github-actions bot removed the runners label Oct 23, 2024
Signed-off-by: s21lee <lsh41777@gmail.com>
@github-actions github-actions bot added runners and removed runners labels Oct 24, 2024
@tvalentyn
Copy link
Contributor

Hi @s21lee - feel free to ping this thread when your change is ready for review.

@tvalentyn
Copy link
Contributor

I'll put the ball in your court for now since some test suites are failing , let us know if you need help.

@tvalentyn
Copy link
Contributor

waiting on author

Signed-off-by: s21lee <lsh41777@gmail.com>
Signed-off-by: s21lee <lsh41777@gmail.com>
Signed-off-by: s21lee <lsh41777@gmail.com>
@github-actions github-actions bot added runners and removed runners labels Oct 25, 2024
Signed-off-by: s21lee <lsh41777@gmail.com>
@github-actions github-actions bot added runners and removed runners labels Oct 25, 2024
Signed-off-by: s21lee <lsh41777@gmail.com>
s21lee and others added 6 commits October 25, 2024 11:30
Signed-off-by: s21lee <lsh41777@gmail.com>
Signed-off-by: s21lee <lsh41777@gmail.com>
Signed-off-by: s21lee <lsh41777@gmail.com>
Signed-off-by: s21lee <lsh41777@gmail.com>
Signed-off-by: s21lee <lsh41777@gmail.com>
@s21lee
Copy link
Author

s21lee commented Oct 25, 2024

@tvalentyn Hi, thank you for your help.
I fixed errors. But the error is left. Do you have an idea fro the error?
https://github.com/apache/beam/actions/runs/11512354850/job/32047261745?pr=32033

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants