Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade google-api-core to mitigate #30927 #31004

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Downgrade google-api-core to mitigate #30927 #31004

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb69643
Exclude currently available GAPIC versions affected by a GRPC regression
tvalentyn Apr 16, 2024
ea42eee
Regenerate dependencies for Python containers.
tvalentyn Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions sdks/python/container/py310/base_image_requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ fastavro==1.9.4
fasteners==0.19
freezegun==1.4.0
future==1.0.0
google-api-core==2.18.0
google-api-python-client==2.125.0
google-api-core==2.16.2
google-api-python-client==2.126.0
google-apitools==0.5.31
google-auth==2.29.0
google-auth-httplib2==0.2.0
Expand Down Expand Up @@ -98,7 +98,7 @@ nose==1.3.7
numpy==1.26.4
oauth2client==4.1.3
objsize==0.7.0
orjson==3.10.0
orjson==3.10.1
overrides==7.7.0
packaging==24.0
pandas==2.0.3
Expand Down Expand Up @@ -130,7 +130,7 @@ pytz==2024.1
PyYAML==6.0.1
redis==5.0.3
referencing==0.34.0
regex==2023.12.25
regex==2024.4.16
requests==2.31.0
requests-mock==1.12.1
rpds-py==0.18.0
Expand Down
8 changes: 4 additions & 4 deletions sdks/python/container/py311/base_image_requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ fastavro==1.9.4
fasteners==0.19
freezegun==1.4.0
future==1.0.0
google-api-core==2.18.0
google-api-python-client==2.125.0
google-api-core==2.16.2
google-api-python-client==2.126.0
google-apitools==0.5.31
google-auth==2.29.0
google-auth-httplib2==0.2.0
Expand Down Expand Up @@ -96,7 +96,7 @@ nose==1.3.7
numpy==1.26.4
oauth2client==4.1.3
objsize==0.7.0
orjson==3.10.0
orjson==3.10.1
overrides==7.7.0
packaging==24.0
pandas==2.0.3
Expand Down Expand Up @@ -128,7 +128,7 @@ pytz==2024.1
PyYAML==6.0.1
redis==5.0.3
referencing==0.34.0
regex==2023.12.25
regex==2024.4.16
requests==2.31.0
requests-mock==1.12.1
rpds-py==0.18.0
Expand Down
8 changes: 4 additions & 4 deletions sdks/python/container/py38/base_image_requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ fastavro==1.9.4
fasteners==0.19
freezegun==1.4.0
future==1.0.0
google-api-core==2.18.0
google-api-python-client==2.125.0
google-api-core==2.16.2
google-api-python-client==2.126.0
google-apitools==0.5.31
google-auth==2.29.0
google-auth-httplib2==0.2.0
Expand Down Expand Up @@ -101,7 +101,7 @@ nose==1.3.7
numpy==1.24.4
oauth2client==4.1.3
objsize==0.7.0
orjson==3.10.0
orjson==3.10.1
overrides==7.7.0
packaging==24.0
pandas==2.0.3
Expand Down Expand Up @@ -134,7 +134,7 @@ pytz==2024.1
PyYAML==6.0.1
redis==5.0.3
referencing==0.34.0
regex==2023.12.25
regex==2024.4.16
requests==2.31.0
requests-mock==1.12.1
rpds-py==0.18.0
Expand Down
8 changes: 4 additions & 4 deletions sdks/python/container/py39/base_image_requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ fastavro==1.9.4
fasteners==0.19
freezegun==1.4.0
future==1.0.0
google-api-core==2.18.0
google-api-python-client==2.125.0
google-api-core==2.16.2
google-api-python-client==2.126.0
google-apitools==0.5.31
google-auth==2.29.0
google-auth-httplib2==0.2.0
Expand Down Expand Up @@ -99,7 +99,7 @@ nose==1.3.7
numpy==1.26.4
oauth2client==4.1.3
objsize==0.7.0
orjson==3.10.0
orjson==3.10.1
overrides==7.7.0
packaging==24.0
pandas==2.0.3
Expand Down Expand Up @@ -131,7 +131,7 @@ pytz==2024.1
PyYAML==6.0.1
redis==5.0.3
referencing==0.34.0
regex==2023.12.25
regex==2024.4.16
requests==2.31.0
requests-mock==1.12.1
rpds-py==0.18.0
Expand Down
4 changes: 3 additions & 1 deletion sdks/python/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,9 @@ def get_portability_package_data():
],
'gcp': [
'cachetools>=3.1.0,<6',
'google-api-core>=2.0.0,<3',
# Temporary workaround until grpcio releases a fix for
# https://github.com/grpc/grpc/issues/36265
'google-api-core>=2.0.0,!=2.17.*,!=2.18.*,<3',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this going to be fixed in google-api-core, or should we just pin to <2.17 until the fix is merged?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will be fixed in grpcio.

Copy link
Contributor Author

@tvalentyn tvalentyn Apr 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an upper bound restriction is prone to cause dependency resolution issues down the road.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a better fix would be to exclude the broken versions of grpcio, but that would revert a recent change to enable Py 3.12 support and I'd prefer to let people to experiment with Py 3.12 as early as possible to gather more feedback even before we officially support it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if grpc team produces a fix in 1.62.2, we can revert this change, regenerate the dependencies and cherry-pick that for 2.56.0.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concern is mostly that if google-api-core releases 2.19 and people are on old grpcio this problem will still exist. I think you're probably right, that is the best option still though.

Hopefully the fix comes in soon and we can cherry-pick in a better patch

'google-apitools>=0.5.31,<0.5.32',
# NOTE: Maintainers, please do not require google-auth>=2.x.x
# Until this issue is closed
Expand Down
Loading