Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C#] Use new decimal.GetBits overloads to reduce allocations when serializing decimal values #44237

Closed
georgevanburgh opened this issue Sep 26, 2024 · 1 comment · Fixed by #44238
Closed

[C#] Use new decimal.GetBits overloads to reduce allocations when serializing decimal values #44237

georgevanburgh opened this issue Sep 26, 2024 · 1 comment · Fixed by #44238
Assignees
@georgevanburgh
Labels
Component: C# Type: enhancement
Milestone
18.0.0

Comments

@georgevanburgh
Copy link
Contributor

georgevanburgh commented Sep 26, 2024 •
edited
Loading

Describe the enhancement requested

Similar to #41349, .NET 5 introduced new overloads for decimalGetBits for which allow the use of a stackalloc'ed span, and avoiding the allocation of a fresh byte array for each value serialized. This should (slightly) reduce the allocations associated with serializing C# decimal values.

arrow/csharp/src/Apache.Arrow/DecimalUtility.cs

Line 226 in 80622fa

int[] decimalBits = decimal.GetBits(value);

Component(s)

C#
@georgevanburgh georgevanburgh mentioned this issue Sep 26, 2024
Merged
@CurtHagenlocher CurtHagenlocher added this to the 18.0.0 milestone Sep 26, 2024
@CurtHagenlocher
Copy link
Contributor

Issue resolved by pull request 44238
#44238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@georgevanburgh georgevanburgh

Labels
Component: C# Type: enhancement
Projects
None yet
Milestone
18.0.0
Development

Successfully merging a pull request may close this issue.

GH-44237: [C#] Use stack allocated buffer when serializing decimal values georgevanburgh/arrow
2 participants
@CurtHagenlocher @georgevanburgh