Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++][Parquet] Benchmarks should present a items/s or bytes/s metric #39668

Closed
Tracked by #39662
pitrou opened this issue Jan 17, 2024 · 5 comments
Closed
Tracked by #39662

[C++][Parquet] Benchmarks should present a items/s or bytes/s metric #39668

pitrou opened this issue Jan 17, 2024 · 5 comments

Comments

@pitrou
Copy link
Member

pitrou commented Jan 17, 2024

Describe the enhancement requested

We should scan through these benchmarks and look for those that only a present an iteration time.

Component(s)

Benchmarking, C++, Parquet

@pitrou
Copy link
Member Author

pitrou commented Jan 23, 2024

cc @mapleFU

@mapleFU
Copy link
Member

mapleFU commented Jan 24, 2024

take

@mapleFU
Copy link
Member

mapleFU commented Jan 26, 2024

Parquet has benchmarks below:

parquet-bloom-filter-benchmark
parquet-arrow-reader-writer-benchmark
parquet-column-reader-benchmark
parquet-page-index-benchmark
parquet-level-conversion-benchmark
parquet-encoding-benchmark
parquet-column-io-benchmark

Seems all benchmark has at least one of items/s or bytes/s metric

@pitrou
Copy link
Member Author

pitrou commented Jan 26, 2024

Thanks for going over this. If it's desirable to add more benchmark metadata still, feel free to post a PR, otherwise this issue should be closed.

@mapleFU
Copy link
Member

mapleFU commented Jan 26, 2024

Let me first close this

@mapleFU mapleFU closed this as completed Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants