Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

values.yaml dags.gitSync.containerLifecycleHooks Does not working #40364

Closed
1 of 2 tasks
chanNamgung opened this issue Jun 21, 2024 · 2 comments · Fixed by #40369
Closed
1 of 2 tasks

values.yaml dags.gitSync.containerLifecycleHooks Does not working #40364

chanNamgung opened this issue Jun 21, 2024 · 2 comments · Fixed by #40369
Assignees
@getChan
Labels
area:helm-chart Airflow Helm Chart kind:bug This is a clearly a bug

Comments

@chanNamgung
Copy link

Official Helm Chart version

1.11.0

Apache Airflow version

2.7.1

Kubernetes Version

1.27

Helm Chart configuration

dags.gitSync.containerLifecycleHooks Does not working.

I think it need to add some commands at git_sync_container in _helpers.yaml

Docker Image customizations

No response

What happened

No response

What you think should happen instead

No response

How to reproduce

  1. set dags.gitSync.containerLifecycleHooks
  2. check git-sync container does not have any hooks

Anything else

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@chanNamgung chanNamgung added area:helm-chart Airflow Helm Chart kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet labels Jun 21, 2024
@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented Jun 21, 2024

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

@getChan
Copy link
Contributor

getChan commented Jun 21, 2024

take

@getChan getChan mentioned this issue Jun 21, 2024
Merged
@nathadfield nathadfield removed the needs-triage label for new issues that we didn't triage yet label Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@getChan getChan

Labels
area:helm-chart Airflow Helm Chart kind:bug This is a clearly a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ADD git-sync container lifecycle hooks getChan/airflow
3 participants
@nathadfield @getChan @chanNamgung