Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EmitWarningsOnPlaceholders("age") (#1997) #2000

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Add EmitWarningsOnPlaceholders("age") (#1997) #2000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions regress/expected/name_validation.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,6 +475,14 @@ NOTICE: graph "graph123" has been dropped

(1 row)

--
-- Test GUC names
--
SET age.enable_containment TO ON;
SET age.invalid_parameter TO ON;
ERROR: invalid configuration parameter name "age.invalid_parameter"
DETAIL: "age" is a reserved prefix.
SET any_placeholder.any_parameter TO ON;
--
-- End of test
--
7 changes: 7 additions & 0 deletions regress/sql/name_validation.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,13 @@ SELECT create_elabel('graph123', 'elabel0123456789012345678901234567890123456789
-- clean up
SELECT drop_graph('graph123', true);

--
-- Test GUC names
--
SET age.enable_containment TO ON;
SET age.invalid_parameter TO ON;
SET any_placeholder.any_parameter TO ON;

--
-- End of test
--
1 change: 1 addition & 0 deletions src/backend/utils/ag_guc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,4 +42,5 @@ void define_config_params(void)
NULL,
NULL,
NULL);
EmitWarningsOnPlaceholders("age");
}
Loading