Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Typography editable focus trigger on mount unexpectedly #48741

Merged
merged 1 commit into from
May 2, 2024

Conversation

afc163
Copy link
Member

@afc163 afc163 commented May 2, 2024

中文版模板 / Chinese template

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

重现方式,本地启动 dev,打开 http://127.0.0.1:8001/components/typography-cn ,渲染完成后会跳到下面去。

📝 Changelog

Language Changelog
🇺🇸 English Fix Typography editable will trigger focus unexpectedly on mounting.
🇨🇳 Chinese 修复 Typography 开启 editable 时会意外触发 focus 事件。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented May 2, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented May 2, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented May 2, 2024

👁 Visual Regression Report for PR #48741 Passed ✅

🎯 Target branch: master (2f304d1)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link
Contributor

github-actions bot commented May 2, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 337.83 KB (+259 B 🔺)
./dist/antd-with-locales.min.js 385.68 KB (+191 B 🔺)

Copy link

codesandbox-ci bot commented May 2, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2f304d1) to head (6cc6cc1).

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #48741   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          745       746    +1     
  Lines        12990     12996    +6     
  Branches      3409      3409           
=========================================
+ Hits         12990     12996    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 merged commit 1598262 into master May 2, 2024
112 checks passed
@afc163 afc163 deleted the fix/edit-icon-focus branch May 2, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants