Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Text Button tokens #47870

Merged
merged 5 commits into from
Sep 18, 2024
Merged

Conversation

madocto
Copy link
Contributor

@madocto madocto commented Mar 14, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close: #47647

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Button add textColor, textHoverColor and textActiveColor tokens.
🇨🇳 Chinese Button 添加 textColortextHoverColortextActiveColor 三个 token。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Mar 14, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Mar 14, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Mar 14, 2024

👁 Visual Regression Report for PR #47870 Passed ✅

🎯 Target branch: feature (5b46765)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link

codesandbox-ci bot commented Mar 14, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5b46765) to head (dc3e235).
Report is 3 commits behind head on feature.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #47870   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          762       762           
  Lines        13499     13499           
  Branches      3509      3509           
=========================================
  Hits         13499     13499           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@madocto madocto requested a review from MadCcc March 14, 2024 07:04
@afc163
Copy link
Member

afc163 commented Sep 3, 2024

冲突了。

Copy link

pkg-pr-new bot commented Sep 11, 2024

@madocto
Copy link
Contributor Author

madocto commented Sep 11, 2024

done

@afc163
Copy link
Member

afc163 commented Sep 18, 2024

@madocto 影响了 demo visual diff,看看。

@afc163
Copy link
Member

afc163 commented Sep 18, 2024

visual diff 还是有些差异。

@madocto
Copy link
Contributor Author

madocto commented Sep 18, 2024

这次是真的好了

@afc163 afc163 merged commit b5b0918 into ant-design:feature Sep 18, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants