-
-
Notifications
You must be signed in to change notification settings - Fork 49.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Form sm 24 not working #44541
Merged
fix: Form sm 24 not working #44541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
size-limit report 📦
|
li-jia-nan
approved these changes
Aug 30, 2023
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #44541 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 665 665
Lines 11276 11304 +28
Branches 3048 3063 +15
=========================================
+ Hits 11276 11304 +28
☔ View full report in Codecov by Sentry. |
MadCcc
approved these changes
Aug 31, 2023
This was referenced Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
fix #44538
💡 Background and solution
v4 is correct https://github.com/ant-design/ant-design/blob/4.x-stable/components/form/style/horizontal.less#L18
📝 Changelog
wrapperCol
to be24
not working whenlabelCol
is set to24
.labelCol
设置为24
时,会使wrapperCol
设置24
失效的问题。☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 609c5d0
Fixed a form style bug and removed unused code in
components/form/style/index.ts
. The bug caused incorrect label alignment for some custom classes.🔍 Walkthrough
🤖 Generated by Copilot at 609c5d0
-24
(link)rootPrefixCls
variable fromgenHorizontalStyle
function (link)