Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix 'span' to 'li' #40867

Merged
merged 1 commit into from
Feb 22, 2023
Merged

fix: fix 'span' to 'li' #40867

merged 1 commit into from
Feb 22, 2023

Conversation

heiyu4585
Copy link
Contributor

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix 'span' to 'li'
🇨🇳 Chinese 修改'Separator'的dom由'span'改为''li''

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Feb 22, 2023

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (29a3145) compared to base (7043cad).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##            master    #40867    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          608       606     -2     
  Lines        10577     10299   -278     
  Branches      2894      2791   -103     
==========================================
- Hits         10577     10299   -278     
Impacted Files Coverage Δ
components/breadcrumb/BreadcrumbSeparator.tsx 100.00% <100.00%> (ø)
components/app/index.tsx 100.00% <0.00%> (ø)
components/app/context.ts 100.00% <0.00%> (ø)
components/tour/index.tsx 100.00% <0.00%> (ø)
components/tooltip/index.tsx 100.00% <0.00%> (ø)
components/_util/placements.ts 100.00% <0.00%> (ø)
components/dropdown/dropdown.tsx 100.00% <0.00%> (ø)
components/popover/PurePanel.tsx 100.00% <0.00%> (ø)
components/image/PreviewGroup.tsx 100.00% <0.00%> (ø)
components/tooltip/style/index.ts 100.00% <0.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163
Copy link
Member

afc163 commented Feb 22, 2023

为啥要改这个

@zombieJ
Copy link
Member

zombieJ commented Feb 22, 2023

dom 变化放到 feature 哈~

@zombieJ zombieJ merged commit b241900 into ant-design:master Feb 22, 2023
@afc163
Copy link
Member

afc163 commented Feb 22, 2023

是不是得把这种 dom 结构也统一了。

图片

heiyu4585 added a commit to heiyu4585/ant-design that referenced this pull request Feb 23, 2023
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 4, 2023
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants