Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TimeLine): Correct className #40700

Merged
merged 2 commits into from
Feb 13, 2023

Conversation

linhf123
Copy link
Contributor

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

none

💡 Background and solution

TimeLine 的 className 会被应用到子元素上
修改前:
48b0332cb6a1eb3a6b217851b6a3bf5c

修改后:
1676259978007_58A0FCB8-3E09-4b7e-8FC8-2A93086DC613

📝 Changelog

Language Changelog
🇺🇸 English Correct className
🇨🇳 Chinese 纠正 className

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2023

@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (6d51bed) compared to base (766e7f8).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #40700   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          606       606           
  Lines        10287     10289    +2     
  Branches      2789      2790    +1     
=========================================
+ Hits         10287     10289    +2     
Impacted Files Coverage Δ
components/timeline/TimelineItemList.tsx 100.00% <ø> (ø)
components/tour/style/index.ts 100.00% <ø> (ø)
components/tour/panelRender.tsx 100.00% <100.00%> (ø)
components/tour/index.tsx 100.00% <0.00%> (ø)
components/tour/PurePanel.tsx 100.00% <0.00%> (ø)
components/date-picker/style/index.ts 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163
Copy link
Member

afc163 commented Feb 13, 2023

来个测试用例

@linhf123
Copy link
Contributor Author

来个测试用例

已添加

@vagusX vagusX merged commit fb5305d into ant-design:master Feb 13, 2023
@MadCcc MadCcc mentioned this pull request Feb 14, 2023
20 tasks
@linhf123 linhf123 deleted the linhf/fix-timeline-className branch February 16, 2023 05:42
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 4, 2023
Co-authored-by: WB780012 <wb-lhf780012@antgroup.com>
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
Co-authored-by: WB780012 <wb-lhf780012@antgroup.com>
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
Co-authored-by: WB780012 <wb-lhf780012@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants