Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong condition set for EFI bootloader path #12

Closed
nvntsin opened this issue Feb 8, 2023 · 0 comments · Fixed by #14
Closed

Wrong condition set for EFI bootloader path #12

nvntsin opened this issue Feb 8, 2023 · 0 comments · Fixed by #14
Assignees
Labels
bug Something isn't working

Comments

@nvntsin
Copy link

nvntsin commented Feb 8, 2023

Describe the Issue
This role is supposedly to be run on AmazonLinux 2 machines only. The prelim.yml task which sets up bootloader path is configured according to CentOS, so on UEFI based EC2, this role failed to set bootloader path correctly, and so handler to generate grub config is failing

Expected Behavior
Bootloader path must be configured as per ansible_distribution == 'Amazon' and not CentOS

Actual Behavior
Bootloader path set_fact is checking for ansible_distribution == 'CentOS', this must be cheking against ansible_distribution == 'Amazon'

Control(s) Affected
HANDLER [AMAZON2-CIS : grub2cfg]

Environment (please complete the following information):
ansible [core 2.14.2]
config file = None
configured module search path = ['/Users/navneet/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
ansible python module location = /opt/homebrew/Cellar/ansible/7.2.0/libexec/lib/python3.11/site-packages/ansible
ansible collection location = /Users/navneet/.ansible/collections:/usr/share/ansible/collections
executable location = /opt/homebrew/bin/ansible
python version = 3.11.1 (main, Dec 23 2022, 09:25:23) [Clang 14.0.0 (clang-1400.0.29.202)] (/opt/homebrew/Cellar/ansible/7.2.0/libexec/bin/python3.11)
jinja version = 3.1.2
libyaml = True

Additional Notes
Anything additional goes here

Possible Solution
Fix bootloader path on EFI images #11

@nvntsin nvntsin added the bug Something isn't working label Feb 8, 2023
@uk-bolly uk-bolly self-assigned this Mar 2, 2023
@uk-bolly uk-bolly linked a pull request Mar 2, 2023 that will close this issue
@uk-bolly uk-bolly mentioned this issue Mar 17, 2023
@uk-bolly uk-bolly linked a pull request Mar 17, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants