Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add google.cloud to Ansible 8 #201

Merged
merged 2 commits into from
Feb 16, 2023

Conversation

mariolenz
Copy link
Collaborator

Keep google.cloud in Ansible 8 as discussed in ansible-community/community-topics#105 and voted on in ansible-community/community-topics#195.

@felixfontein
Copy link
Contributor

I think we should also state this in the Ansible 7 changelog, since we already announced the removal there.

@mariolenz
Copy link
Collaborator Author

@felixfontein Good point, but where? We don't have an UNdeprecated_features section.

Should I use the deprecated_features section and write there that the deprecation has been canceled?

@mariolenz
Copy link
Collaborator Author

What do you think about this:

deprecated_features:
 - Since the google.cloud collection seems to be maintained again, we
   `cancelled the removal process <https://github.com/ansible-collections/overview/blob/main/removal_from_ansible.rst#cancelling-removal-of-an-unmaintained-collection>`__.
   So contrary to an earlier announcement, this collection is NOT deprecated and will NOT be removed from Ansible 8
   (https://github.com/ansible-community/community-topics/issues/105).

Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good!

(One thing one could discuss is whether to remove / update the earlier deprecation in the Ansible 7 changelog. I don't really like touching changelogs of released versions, though...)

@mariolenz
Copy link
Collaborator Author

One thing one could discuss is whether to remove / update the earlier deprecation in the Ansible 7 changelog. I don't really like touching changelogs of released versions, though...

I don't think it's a good idea to touch changelogs of released versions, either.

@felixfontein
Copy link
Contributor

@mariolenz thanks for implementing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants