k8s_cp: add support for check_mode, fix doc issue, remove dependency with 'find' when state=from_pod #512
Conversation
|
recheck |
|
recheck |
|
recheck |
|
This change depends on a change that failed to merge. |
|
recheck |
|
This change depends on a change that failed to merge. |
|
recheck |
|
This change depends on a change that failed to merge. |
|
recheck |
|
recheck |
|
This change depends on a change that failed to merge. |
|
recheck |
|
This change depends on a change that failed to merge. |
|
recheck |
|
This change depends on a change that failed to merge. |
|
recheck |
|
This change depends on a change that failed to merge. |
|
recheck |
|
This change depends on a change that failed to merge. |
|
recheck |
|
This change depends on a change that failed to merge. |
|
recheck |
1 similar comment
|
recheck |
|
This change depends on a change that failed to merge. |
1 similar comment
|
This change depends on a change that failed to merge. |
|
recheck |
|
recheck |
|
recheck |
|
The tests are faster, I'm not sure if the k8s_user_impersonation can just be ignored. |
|
recheck |
|
This change depends on a change that failed to merge. |
|
recheck |
|
recheck |
|
recheck |
abikouo
force-pushed
the
k8s_copy_from_pod_remove_find
branch
from
9fe2924
to
a1bfd4a
Compare
…last example, find executable is not longer required when state=from_pod
abikouo
force-pushed
the
k8s_copy_from_pod_remove_find
branch
from
9871c99
to
8b1c647
Compare
| return files | ||
|
|
||
| def listfile_with_echo(self, path): | ||
| echo_cmd = [self.pod_shell, "-c", "echo {path}/* {path}/.*".format(path=path)] |
There was a problem hiding this comment.
@abikouo This is still broken when there is a directory with a space in it. When there is a space, this command ends up as:
/bin/sh -c "echo foobar/foo baz/* foobar/foo baz/.*"
which won't expand to anything because the path does not exist. You need to escape the space in the directory name. In addition to fixing this, can you please add a test for copying from a remote path with both a directory and a file that have a space in their names?
There was a problem hiding this comment.
@gravesm the pull request is here https://github.com/ansible-collections/kubernetes.core/pull/552/files
k8s_cp - fix issue when directory contains space in its name Depends-On: #549 SUMMARY There is a remaining issue not addressed by #512 when copying directory from Pod to local filesystem, if the directory contains space into its name, the directory was not copied ISSUE TYPE Bugfix Pull Request COMPONENT NAME k8s_cp ADDITIONAL INFORMATION Reviewed-by: Mike Graves <mgraves@redhat.com> Reviewed-by: Bikouo Aubin <None>
Depends-On: ansible/ansible-zuul-jobs#1635
Depends-On: ansible/ansible-zuul-jobs#1636
Depends-On: #518
Depends-On: #520
SUMMARY
for check_mode, closes k8s_cp module does not support check_mode #380state=from_pod, closes k8s_cp state=from_pod requires 'find' binary to be present on the remote pod #486ISSUE TYPE